Return-Path: X-Original-To: apmail-incubator-celix-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-celix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD6CC10FE4 for ; Thu, 12 Dec 2013 19:26:50 +0000 (UTC) Received: (qmail 66827 invoked by uid 500); 12 Dec 2013 19:26:50 -0000 Delivered-To: apmail-incubator-celix-dev-archive@incubator.apache.org Received: (qmail 66811 invoked by uid 500); 12 Dec 2013 19:26:50 -0000 Mailing-List: contact celix-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: celix-dev@incubator.apache.org Delivered-To: mailing list celix-dev@incubator.apache.org Received: (qmail 66803 invoked by uid 99); 12 Dec 2013 19:26:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Dec 2013 19:26:50 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of gerritbinnenmars@gmail.com designates 209.85.215.171 as permitted sender) Received: from [209.85.215.171] (HELO mail-ea0-f171.google.com) (209.85.215.171) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Dec 2013 19:26:42 +0000 Received: by mail-ea0-f171.google.com with SMTP id h10so451617eak.30 for ; Thu, 12 Dec 2013 11:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=FFJXiqFVLwXTj04Gf03OLN81x0GdyuruSfx8TMPXQqE=; b=KCchPXqL6Nz0pscaLrUnPUzcgdyKitwLpY/RTCcvTPwqZz2lOjYT8+8ZW4mCCwOxoB wOlK7alNWW+Y6PTej2nJlufNfavFfCdOtniJqnKgbuJtefmxJ1AwTvsIi7PxR2NvF4mu +nCAMp/tjgnH4/bHaIQBODautTwLskAO/Lq32ynmnAzKr0RgUew22CwQFkpJVegs3NRg lG90/sgEzYpn3mv4FKOfoXLRBjRZfby4yhNVP1luPN9MOZ05J0Ir449Ng2rK9jUKG0vn VjPb5ydO98n8HtyKRq/2KKqCo9aDp9hya0e4d+vUg8RICv8Aw5aWDWwM5s1clnaB7Wac IKvA== X-Received: by 10.14.105.7 with SMTP id j7mr9588530eeg.95.1386876010738; Thu, 12 Dec 2013 11:20:10 -0800 (PST) Received: from [192.168.1.73] (ip4da93436.direct-adsl.nl. [77.169.52.54]) by mx.google.com with ESMTPSA id a45sm69239961eem.6.2013.12.12.11.20.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Dec 2013 11:20:09 -0800 (PST) Message-ID: <52AA0C64.9090105@gmail.com> Date: Thu, 12 Dec 2013 20:20:04 +0100 From: Gerrit Binnenmars User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: celix-dev@incubator.apache.org Subject: Re: celix log levels References: <5fd2842bb494b7f8330d4c62f002e5fa@imap.sundevil.de> In-Reply-To: <5fd2842bb494b7f8330d4c62f002e5fa@imap.sundevil.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hello Bjorn, It is a good proposal, so just do it and make a patch for Celix. I can imagine that there are a lot more "prefixes"missing? Greetings Gerrit > > > Hi all, > > While coupling a log_writer to syslog, I recognized that celix has > some log levels (as enum in log_service.h) which are already defined > within syslog. As I want to prevent strange #undefine's in my code and > changing syslog is obviously not a solution, I would propose to add a > "CELIX_" prefix to the log levels. > > As this implies a change to several source-files, I would like to ask > whether there are any objections or other proposals? > > Regards, > Bjoern