Return-Path: X-Original-To: apmail-incubator-celix-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-celix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEA9110011 for ; Sun, 11 Aug 2013 10:16:53 +0000 (UTC) Received: (qmail 10893 invoked by uid 500); 11 Aug 2013 10:16:51 -0000 Delivered-To: apmail-incubator-celix-dev-archive@incubator.apache.org Received: (qmail 10834 invoked by uid 500); 11 Aug 2013 10:16:50 -0000 Mailing-List: contact celix-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: celix-dev@incubator.apache.org Delivered-To: mailing list celix-dev@incubator.apache.org Received: (qmail 10826 invoked by uid 99); 11 Aug 2013 10:16:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Aug 2013 10:16:48 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jsm12gc@gmail.com designates 209.85.214.43 as permitted sender) Received: from [209.85.214.43] (HELO mail-bk0-f43.google.com) (209.85.214.43) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Aug 2013 10:16:41 +0000 Received: by mail-bk0-f43.google.com with SMTP id mz13so1510922bkb.2 for ; Sun, 11 Aug 2013 03:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=ryAttG+dMTvGBgXOAByLtJ+I8aPdPOEWO0V9I/N5VS8=; b=zSK35ze0m5Xqp5cNn1Se7islVvSJzv5AmAPcjaglALrXalVSdkOCaiCkX3FH43DG3l db51t/5XI3DeDB2wWpVFpoNX0S6zYu02dQwyz2hfkPvf8mlYce3zjDFEVA6fSFIaNrJU ucKIyiEQnMbJqjwJBuXvvYyqO+v6xIbHIqzIpxsJsmCfIWpOARPmArImjfN7cFFpkgH1 zq/f6f+rMV4iE/bYf499CP5bPCOz4V4B0m5aDRyVqYW0XGFMQoyNPqJcK1VkkLUyoRjF FLJMWlP7x6VogEtCfFZ/EpQHBAUKgKzlG1bn4izPtXIymRvdDDZHqpuMelWhhihsDFxB 7w/w== X-Received: by 10.204.173.69 with SMTP id o5mr3108992bkz.100.1376216180537; Sun, 11 Aug 2013 03:16:20 -0700 (PDT) Received: from [192.168.1.199] (46.128.26.48.dynamic.cablesurf.de. [46.128.26.48]) by mx.google.com with ESMTPSA id h5sm4538917bkg.8.2013.08.11.03.16.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 11 Aug 2013 03:16:20 -0700 (PDT) Message-ID: <52076473.60009@gmail.com> Date: Sun, 11 Aug 2013 12:16:19 +0200 From: Jorge SANCHEZ User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: celix-dev@incubator.apache.org Subject: Re: [ CELIX ]: Contributing References: <52062D49.4040507@gmail.com> In-Reply-To: Content-Type: multipart/alternative; boundary="------------090108080804070904030302" X-Virus-Checked: Checked by ClamAV on apache.org --------------090108080804070904030302 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Hi all, The issue's number is CELIX-77 and the work is attached in a zip file in the issue. The link to the issue is: https://issues.apache.org/jira/browse/CELIX-77 Greetings, Jorge On 08/11/2013 12:07 PM, Mohammad Nour El-Din wrote: > Hi > > @Pepijn: Welcome back ;) > > > @Jorge: Great news. As a friendly note, it would be better to mention the > JIRA issue's number that you are working on and attached your patch to so > you give a better chance for your work to be reviewed by more people and > hence either get committed fast or you get feedback soon enough. But other > than that great work ;) > > > On Sat, Aug 10, 2013 at 8:46 PM, Pepijn Noltes wrote: > >> Hi Jorge, >> >> On Sat, Aug 10, 2013 at 2:08 PM, Jorge SANCHEZ wrote: >>> I uploaded my work. Sorry for the delay, I went on holidays, busy new >> city >>> moving, new assignment, ... but the most important, the work is in JIRA >> ;). >> >> Good news. Thanks for donating your work to Celix :) >> When I have time I will review, discuss and/or commit the code. I will >> probably start with this next week, after my holiday. >> >> Greetings, >> Pepijn >> >> >>> Friendly greetings, >>> Jorge >>> >>> >>> >>> On 07/30/2013 05:14 PM, Mohammad Nour El-Din wrote: >>>> Hi Jorge >>>> >>>> Nice to see you on the mailing list ;) >>>> >>>> What I suggest you to do is to JIRA at [1], create an account for JIRA >> if >>>> you don't already have one, look if there is already a JIRA issue >> related >>>> to the work you have done, if not create one and give it some good >>>> description then attach a patch to it and eventually someone with commit >>>> rights should pick it up, review it and then commit it for you >>>> >>>> If there is already a JIRA related to what you have done just attach the >>>> patch file it >>>> >>>> In either case also add a comment explaining what you have done in the >>>> patch. I would also be much better you besides that you send an e-mail >> to >>>> this mailing list explaining the changes you have made, any impacts if >>>> any, >>>> etc... >>>> >>>> For the license header thing, you are basicly right, but the committer >> who >>>> will pick you patch should also review these aspect and give you a >>>> feedback >>>> and by time you will learn ;). It is also good to read [2] for general >>>> information about contribution >>>> >>>> Have fun ;) >>>> >>>> [1] https://issues.apache.org/jira/browse/CELIX >>>> [2] http://www.apache.org/dev/#committers >>>> >>>> On Sun, Jul 28, 2013 at 10:51 AM, Jorge SM wrote: >>>> >>>>> Hi all, >>>>> >>>>> I�m Jorge. I was trainee at Thales not so far (my supervisor was Pepijn >>>>> Noltes, already member of Celix) and I would like to contribute myself >> my >>>>> work done in Thales. Giving more info of my work, I started an >>>>> implementation of the ConfigAdmin Service. I'd like if anyone can teach >>>>> me >>>>> how to solve the problem of licenses and what shall I do to give freely >>>>> my >>>>> work to the community, I'm newbie in all this and I don�t have it clear >>>>> yet, I�m only aware, please correct me if I' wrong, that I�m have to >>>>> include a specific block text at the beginning of every header file, in >>>>> any >>>>> case with your help you will show what to do and what is best. >>>>> >>>>> Friendly greetings, >>>>> Jorge >>>>> >>>> > > --------------090108080804070904030302--