celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Broekhuis <a.broekh...@gmail.com>
Subject Re: [RFC] [PATCH v1 0/9] More Fixes
Date Sat, 14 Jul 2012 07:09:00 GMT
Hi Ferry,

Thanks for the patches! I'll look into it tomorrow or somewhere next week.

Some things I notice:

Eclipse path: normally eclipse should pick up the includes itself if
compilation is done from within eclipse. I do have mixed result with this
however, so I'll check if the mentioned includes are any problem.

Added linux/limits.h: Celix doesn't only target Linux as platform, as such
I don't think those should be added. What are the errors/warnings resulting
in this needed header? I think it is important to keep the code clean from
platform specific solutions (at least, all new code, I guess several older
parts aren't that clean). But everything at least also compiles on OSX,
which definitely doesn't have a linux/limits.h.
If something is going wrong we'll have to check out a platform independent
solution.

The others I'll need to check out.


-- 
Met vriendelijke groet,

Alexander Broekhuis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message