Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 33407200C6E for ; Mon, 8 May 2017 20:50:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 31EE4160BBF; Mon, 8 May 2017 18:50:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79D3D160BA2 for ; Mon, 8 May 2017 20:50:07 +0200 (CEST) Received: (qmail 11589 invoked by uid 500); 8 May 2017 18:50:06 -0000 Mailing-List: contact commits-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list commits@celix.apache.org Received: (qmail 11580 invoked by uid 500); 8 May 2017 18:50:06 -0000 Delivered-To: apmail-incubator-celix-commits@incubator.apache.org Received: (qmail 11577 invoked by uid 99); 8 May 2017 18:50:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 18:50:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3AD2ECA9F4 for ; Mon, 8 May 2017 18:50:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tCeFN-7e4rVQ for ; Mon, 8 May 2017 18:50:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 088EF5F568 for ; Mon, 8 May 2017 18:50:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 57BADE0641 for ; Mon, 8 May 2017 18:50:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1144321DF6 for ; Mon, 8 May 2017 18:50:04 +0000 (UTC) Date: Mon, 8 May 2017 18:50:04 +0000 (UTC) From: "Pepijn Noltes (JIRA)" To: celix-commits@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CELIX-407) Extract pubsub_serializer from pubsub_admin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 May 2017 18:50:08 -0000 [ https://issues.apache.org/jira/browse/CELIX-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001324#comment-16001324 ] Pepijn Noltes commented on CELIX-407: ------------------------------------- [~rlenferink] As discussed per mail, I prefer that the pubsubadmins will be created per serialiser service. This means that the pubsubadmin do not get more complex because of the serrializer, because for the lifespan of the admins there are considered constant. The activators for the admins should of course then arrange that new admins are created when serialisers become available and admins are removed when serializer are removed. Also the discovery properties for publishers (or subscribers) should be extended with the serializers info and the match functions should take this into account. Lastly, It would also be nice to have a distributed test setup using the add_runtime commands, so that also the pubsub admin has a decent code coverage. > Extract pubsub_serializer from pubsub_admin > ------------------------------------------- > > Key: CELIX-407 > URL: https://issues.apache.org/jira/browse/CELIX-407 > Project: Celix > Issue Type: Improvement > Reporter: Roy Lenferink > Fix For: next > > > At the moment, the pubsub_admin is responsible for both communication and serialization. It would be better to extract the serializer from the pubsub_admin. -- This message was sent by Atlassian JIRA (v6.3.15#6346)