celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CELIX-371) Due to a fixed maximum length of lines in property file not all bundles are started
Date Fri, 22 Jul 2016 20:38:20 GMT

    [ https://issues.apache.org/jira/browse/CELIX-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390157#comment-15390157
] 

ASF GitHub Bot commented on CELIX-371:
--------------------------------------

GitHub user ErjanAltena opened a pull request:

    https://github.com/apache/celix/pull/6

    CELIX-371: properties_loadWithStream does not use fixed-sized buffers…

    Fix for CELIX_371. The properties_loadWithStream function does not rely on fixed buffer
sizes any more. Checked with valgrind that there are no memory leaks.
    
    Also put part of the properties_loadWithStream in a separate fucntion since it was quite
big.
    
    Regards,
    Erjan Altena

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ErjanAltena/celix develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/celix/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 0a4c93a5050d51f62f8c60170b394d5ceec8537b
Author: Erjan Altena <erjan@localhost.localdomain>
Date:   2016-07-22T20:30:34Z

    CELIX-371: properties_loadWithStream does not use fixed-sized buffers any more

----


> Due to a fixed maximum length of lines in property file not all bundles are started
> -----------------------------------------------------------------------------------
>
>                 Key: CELIX-371
>                 URL: https://issues.apache.org/jira/browse/CELIX-371
>             Project: Celix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Erjan Altena
>
> When Celix starts up it reads the config.properties file line by line. These lines are
placed in a buffer with a fixed length of 1024 characters.
> The Celix build environment creates a deployment with a  config.properties with an absolute
path. Due to this the limit of 1024 characters is reached quite soon (I used 8 bundles).
> There should not be a limit on the maximum line length (or it should be ridiculous big)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message