celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnol...@apache.org
Subject [2/2] celix git commit: CELIX-370: disable -Wall -Werror for C++. apparently cpputest still contains warnings..
Date Thu, 21 Jul 2016 12:29:44 GMT
CELIX-370: disable -Wall -Werror for C++. apparently cpputest still contains warnings..


Project: http://git-wip-us.apache.org/repos/asf/celix/repo
Commit: http://git-wip-us.apache.org/repos/asf/celix/commit/8160dec5
Tree: http://git-wip-us.apache.org/repos/asf/celix/tree/8160dec5
Diff: http://git-wip-us.apache.org/repos/asf/celix/diff/8160dec5

Branch: refs/heads/develop
Commit: 8160dec5d74d32f94d4a2778b8835c4b0efe190e
Parents: e175c80
Author: Pepijn Noltes <pepijnnoltes@gmail.com>
Authored: Thu Jul 21 14:28:42 2016 +0200
Committer: Pepijn Noltes <pepijnnoltes@gmail.com>
Committed: Thu Jul 21 14:28:42 2016 +0200

----------------------------------------------------------------------
 CMakeLists.txt                            | 2 +-
 utils/private/test/celix_threads_test.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/celix/blob/8160dec5/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index dfeb999..6b01ce7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -37,7 +37,7 @@ IF (ANDROID)
 ENDIF()
 IF(UNIX AND NOT ANDROID)
     SET(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -Wall -Werror -fPIC ${CMAKE_C_FLAGS}")
-    SET(CMAKE_CXX_FLAGS "-std=c++11 -Wall -Werror ${CMAKE_CXX_FLAGS}")
+    SET(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}") #TODO enable -Wall -Werror ->
warning in cpputest
 ENDIF()
 IF(UNIX AND NOT APPLE) 
 	SET(CMAKE_C_FLAGS "-pthread ${CMAKE_C_FLAGS}")

http://git-wip-us.apache.org/repos/asf/celix/blob/8160dec5/utils/private/test/celix_threads_test.cpp
----------------------------------------------------------------------
diff --git a/utils/private/test/celix_threads_test.cpp b/utils/private/test/celix_threads_test.cpp
index ff9d277..b22ba9d 100644
--- a/utils/private/test/celix_threads_test.cpp
+++ b/utils/private/test/celix_threads_test.cpp
@@ -67,7 +67,7 @@ static int celix_thread_t_equals(const void * object, const void * compareTo){
 static char * celix_thread_t_toString(const void * object){
 	celix_thread_t * thread = (celix_thread_t*) object;
 	char buff[512];
-	snprintf(buff, 512, "thread: %lu, threadInitialized: %s", thread->thread, (thread->threadInitialized
? "true" : "false"));
+	snprintf(buff, 512, "thread: %lu, threadInitialized: %s", (unsigned long)thread->thread,
(thread->threadInitialized ? "true" : "false"));
 
 	return my_strdup(buff);
 }


Mime
View raw message