celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnol...@apache.org
Subject [08/50] celix git commit: CELIX-335: Cleanup of unneeded commands/comments in Packaging.cmake
Date Mon, 11 Apr 2016 12:00:17 GMT
CELIX-335: Cleanup of unneeded commands/comments in Packaging.cmake


Project: http://git-wip-us.apache.org/repos/asf/celix/repo
Commit: http://git-wip-us.apache.org/repos/asf/celix/commit/1d00b446
Tree: http://git-wip-us.apache.org/repos/asf/celix/tree/1d00b446
Diff: http://git-wip-us.apache.org/repos/asf/celix/diff/1d00b446

Branch: refs/heads/master
Commit: 1d00b446b494b77067d42ae21ba512621777568f
Parents: 8a8292b
Author: Pepijn Noltes <pepijnnoltes@gmail.com>
Authored: Thu Feb 4 15:21:38 2016 +0100
Committer: Pepijn Noltes <pepijnnoltes@gmail.com>
Committed: Thu Feb 4 15:21:38 2016 +0100

----------------------------------------------------------------------
 cmake/cmake_celix/Packaging.cmake | 3 ---
 1 file changed, 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/celix/blob/1d00b446/cmake/cmake_celix/Packaging.cmake
----------------------------------------------------------------------
diff --git a/cmake/cmake_celix/Packaging.cmake b/cmake/cmake_celix/Packaging.cmake
index 3fcf070..ccdc33c 100644
--- a/cmake/cmake_celix/Packaging.cmake
+++ b/cmake/cmake_celix/Packaging.cmake
@@ -71,8 +71,6 @@ function(set_library_version TARGET VERSION)
         #This is simpeler than using the <current>:<revision>:<age> approach
of libtool
         set_property(TARGET ${TARGET} PROPERTY VERSION "${VERSION}")
         set_property(TARGET ${TARGET} PROPERTY SOVERSION ${MAJOR})
-        #set_property(TARGET ${TARGET} PROPERTY VERSION "${VERSION}")
-        #message("target '${TARGET}' with provided version '${VERSION}' has version parts:
'${MAJOR}' '${MINOR}' '${PATCH}'")
     else ()
         message(WARNING "set_library_version: Cannot set version info TARGET and/or VERSION
not provided")
     endif ()
@@ -151,7 +149,6 @@ function(add_bundle)
         add_library(${BUNDLE_TARGET_NAME} SHARED ${BUNDLE_SOURCES})
         set_library_version(${BUNDLE_TARGET_NAME} ${BUNDLE_VERSION})
         set_target_properties(${BUNDLE_TARGET_NAME} PROPERTIES "BUNDLE_TARGET_IS_LIB" TRUE)
-        add_dependencies(bundles ${BUNDLE_TARGET_NAME})
     else()
         add_custom_target(${BUNDLE_TARGET_NAME})
     endif()


Mime
View raw message