celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Menno van der Graaf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CELIX-332) filter tests absent, small bugs in the source
Date Mon, 11 Jan 2016 10:38:39 GMT

    [ https://issues.apache.org/jira/browse/CELIX-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091754#comment-15091754
] 

Menno van der Graaf commented on CELIX-332:
-------------------------------------------

oh, the mentioned style errors (see description), are mostly missing "static" denoters, these
are added in my local source, but not in the patch's diff..
this might possibly cause some merge errors, will look into fixing the patch


> filter tests absent, small bugs in the source
> ---------------------------------------------
>
>                 Key: CELIX-332
>                 URL: https://issues.apache.org/jira/browse/CELIX-332
>             Project: Celix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Menno van der Graaf
>            Priority: Minor
>         Attachments: filter_crashes_and_test.patch
>
>
> there are no tests for "framework/filter.c".
> after a short look at the source i found some small style errors,
> there is also rumored to be a memory leak in the recursive part of the filter functions,
have not found it yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message