celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Menno van der Graaf (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CELIX-325) Bundle test sporadicly fails
Date Mon, 14 Dec 2015 15:36:46 GMT

     [ https://issues.apache.org/jira/browse/CELIX-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Menno van der Graaf updated CELIX-325:
--------------------------------------
    Attachment: bundle_test_random_failure.patch

since the last actual call that did happen is "module_create", which call can be found at:
at bundle.c:222 in bundle_createModule
by bundle.c:395 in bundle_revise
by bundle_test.cpp:673 bundle_revise_test

i can only imagine that the return value of bundle_createModule is not NULL, causing the test
to enter the branch "*module != NULL" at bundle.c:224

i have attached a patch that adds the explicit return of NULL

hope that this fixes the random behavior, no success guaranteed

> Bundle test sporadicly fails
> ----------------------------
>
>                 Key: CELIX-325
>                 URL: https://issues.apache.org/jira/browse/CELIX-325
>             Project: Celix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Menno van der Graaf
>            Priority: Minor
>         Attachments: bundle_test_random_failure.patch
>
>
> The bundle test seems to randomly fail on travis builds, cannot reproduce it localy.
> travis test output is:
> Test command: 
> /home/travis/build/apache/celix/build/framework/bundle_test
> Test timeout computed to be: 9.99988e+06
> ........... 
> /home/travis/build/apache/celix/framework/private/test/bundle_test.cpp:633: 
> error: Failure in TEST(bundle, revise)
> Mock Failure: Unexpected call to function: module_getVersion
> EXPECTED calls that did NOT happen:
> bundleArchive_revise -> void* archive: <0x2>, const char* location: <location>,
const char* inputFile: <inputFile>
> bundleArchive_getCurrentRevision -> void* archive: <0x2>const void* revision:
<output>
> bundleRevision_getManifest -> void* revision: <0xf1ec50>const void* manifest:
<output>
> bundleArchive_getId -> void* archive: <0x2>const void* id: <output>
> resolver_addModule -> void* module: <0x0>
> ACTUAL calls that did happen (in call order):
> bundleArchive_revise -> void* archive: <0x2>, const char* location: <location>,
const char* inputFile: <inputFile>
> bundleArchive_getCurrentRevision -> void* archive: <0x2>const void* revision:
<output>
> bundleRevision_getManifest -> void* revision: <0xf1ec50>const void* manifest:
<output>
> bundleArchive_getId -> void* archive: <0x2>const void* id: <output>
> module_create -> void* headerMap: <0xf222d0>, const char* moduleId: <666.0>,
void* bundle: <0xf21d20>
> .....................
> Errors (1 failures, 32 tests, 32 ran, 244 checks, 0 ignored, 0 filtered out, 2 
> 9/32 Test  #9: bundle_test .......................***Failed    0.01 sec



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message