celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Menno van der Graaf (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CELIX-320) outdated utils tests (threads, hashmap)
Date Thu, 10 Dec 2015 13:50:10 GMT

     [ https://issues.apache.org/jira/browse/CELIX-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Menno van der Graaf updated CELIX-320:
--------------------------------------
    Attachment: utils_tests_threads_hashmap_cmakelist_fixed.patch

sorry, the patch i attached missed an line in the CMakeList: the "UTILS-TEST" option was used
in an "if" statement, but not included in the relevant "endif"
attached the fixed version of the patch

> outdated utils tests (threads, hashmap)
> ---------------------------------------
>
>                 Key: CELIX-320
>                 URL: https://issues.apache.org/jira/browse/CELIX-320
>             Project: Celix
>          Issue Type: Improvement
>          Components: Utils
>            Reporter: Menno van der Graaf
>            Priority: Minor
>         Attachments: utils_tests_threads_hashmap_cmakelist_fixed.patch
>
>
> the celix_threads tests are outdated/missing: no tests for the r/w-lock, no test for
the thread_kill
> there is a compile warning in the hashmap tests: comparing the pointer of a function
pointer, instead of the function pointer itself
> the utils CMakeList is incorrect: some old statements still commented, the new celix_threads
tests require an extra library linked, the option "UTILS-TESTS" is declared but not used



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message