Return-Path: X-Original-To: apmail-celix-commits-archive@www.apache.org Delivered-To: apmail-celix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35437186D7 for ; Wed, 11 Nov 2015 13:49:11 +0000 (UTC) Received: (qmail 84466 invoked by uid 500); 11 Nov 2015 13:49:11 -0000 Delivered-To: apmail-celix-commits-archive@celix.apache.org Received: (qmail 84438 invoked by uid 500); 11 Nov 2015 13:49:11 -0000 Mailing-List: contact commits-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list commits@celix.apache.org Received: (qmail 84428 invoked by uid 500); 11 Nov 2015 13:49:11 -0000 Delivered-To: apmail-incubator-celix-commits@incubator.apache.org Received: (qmail 84423 invoked by uid 99); 11 Nov 2015 13:49:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 13:49:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E3EB02C14F8 for ; Wed, 11 Nov 2015 13:49:10 +0000 (UTC) Date: Wed, 11 Nov 2015 13:49:10 +0000 (UTC) From: "Menno van der Graaf (JIRA)" To: celix-commits@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CELIX-290) Mock fixes, CMakelist fix, build warning fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CELIX-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Menno van der Graaf updated CELIX-290: -------------------------------------- Attachment: fw_test.patch patch file, implements the mentioned fixes for this issue > Mock fixes, CMakelist fix, build warning fix > -------------------------------------------- > > Key: CELIX-290 > URL: https://issues.apache.org/jira/browse/CELIX-290 > Project: Celix > Issue Type: Bug > Components: Framework > Reporter: Menno van der Graaf > Labels: newbie, patch, test > Attachments: fw_test.patch > > > Bugs: > -unit tests failing, exhibiting undefined behavior. the framework mocks are incorrectly implemented, and as a result, the reliant tests fail. > -Cmake warning in framework "framework/Cmakelist.txt" > -sub-par coverage of framework "resolver.c" > -build warnings in the framework unit tests. > Please find attached the patch that implements the following: > Changes/fixes: > -fixed cmake warning in framework/CMakelist.txt (removed brackets from [COPYONLY] at line 351/353) > -fixed build warning in framework bundle_cache_test.cpp (mktemp depricated, used mkstemp instead) > -fixed a dev note accidentaly left in framework service_registry_test.cpp (used preprocessor symbol as dev note, will not do again) > -fixed a lot of the framework mocks, used to not assign any of the output parameters, resulting in undefined behaviour > -updated most framework tests to accommodate for the mock changes > -expanded framework resolver test (WIP) > now how does this patch stuff work.. -- This message was sent by Atlassian JIRA (v6.3.4#6332)