celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bjoern Petri (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CELIX-243) RSA replyStatus is independent of HTTP return code
Date Fri, 26 Jun 2015 13:10:04 GMT

     [ https://issues.apache.org/jira/browse/CELIX-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bjoern Petri updated CELIX-243:
-------------------------------
    Description: 
remoteServiceAdmin_send does have a out-param replyStatus, which indicates whether the curl
request was executed without error. In addition remoteServiceAdmin_send returns a CELIX_ILLEGAL_STAE
in case curl_easy_init failed. 

There is no indication for the caller, whether a Server or Client Error occured!

My proposal would be to 
* return a CELIX_ILLEGAL_STATE when the curl_easy_perform returns an error (e.g. UNSUPPORTED
PROTOCOL)
* return the http code in the replyState (be aware that the replyState would be set to 200
in case of success)



  was:
remoteServiceAdmin_send does have a out-param replyStatus, which indicates whether the curl
request was executed without error. In addition remoteServiceAdmin_send returns a CELIX_ILLEGAL_STAE
in case curl_easy_init failed. 

There is no indication for the caller, whether a Server or Client Error occured!

My proposal would be to 
* return a CELIX_ILLEGAL_STATE when the curl_easy_perform returns an error (e.g. UNSUPPORTED
PROTOCOL)
* return the http code in the replyState (be aware that the replyState would be set to 204
in case of success)




> RSA replyStatus is independent of HTTP return code
> --------------------------------------------------
>
>                 Key: CELIX-243
>                 URL: https://issues.apache.org/jira/browse/CELIX-243
>             Project: Celix
>          Issue Type: Improvement
>            Reporter: Bjoern Petri
>            Priority: Minor
>
> remoteServiceAdmin_send does have a out-param replyStatus, which indicates whether the
curl request was executed without error. In addition remoteServiceAdmin_send returns a CELIX_ILLEGAL_STAE
in case curl_easy_init failed. 
> There is no indication for the caller, whether a Server or Client Error occured!
> My proposal would be to 
> * return a CELIX_ILLEGAL_STATE when the curl_easy_perform returns an error (e.g. UNSUPPORTED
PROTOCOL)
> * return the http code in the replyState (be aware that the replyState would be set to
200 in case of success)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message