Return-Path: X-Original-To: apmail-celix-commits-archive@www.apache.org Delivered-To: apmail-celix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E128F10093 for ; Wed, 7 Jan 2015 22:40:34 +0000 (UTC) Received: (qmail 96773 invoked by uid 500); 7 Jan 2015 22:40:36 -0000 Delivered-To: apmail-celix-commits-archive@celix.apache.org Received: (qmail 96745 invoked by uid 500); 7 Jan 2015 22:40:36 -0000 Mailing-List: contact commits-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list commits@celix.apache.org Received: (qmail 96733 invoked by uid 500); 7 Jan 2015 22:40:36 -0000 Delivered-To: apmail-incubator-celix-commits@incubator.apache.org Received: (qmail 96730 invoked by uid 99); 7 Jan 2015 22:40:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2015 22:40:36 +0000 Date: Wed, 7 Jan 2015 22:40:35 +0000 (UTC) From: "Daniel Parker (JIRA)" To: celix-commits@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CELIX-171) malloc() buffer overflows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CELIX-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Parker resolved CELIX-171. --------------------------------- Resolution: Duplicate These memory allocation issues have been fixed by other bug fixes. > malloc() buffer overflows > ------------------------- > > Key: CELIX-171 > URL: https://issues.apache.org/jira/browse/CELIX-171 > Project: Celix > Issue Type: Bug > Components: Framework, Remote Service Admin > Reporter: Daniel Parker > > framework/private/src/filter.c::filter_parseValue() initializes a local string by calling strcup("") rather than actually allocating enough memory to store the resulting string. > framework/private/src/filter.c::filter_parseSubstring() uses strlen() to determine how much memory to allocate, but the actual worst case size is the length of the string plus one for the trailing '\0'. > remote_services/discovery/private/src/discovery_activator.c::bundleActivator_start() sets 'scope[len] = 0', which is one character past the end of the allocated memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)