celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Parker (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (CELIX-198) Logging can segfault for strings 512 characters or longer
Date Wed, 07 Jan 2015 21:48:35 GMT

     [ https://issues.apache.org/jira/browse/CELIX-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Daniel Parker reopened CELIX-198:

Now the logging itself works, but the 'log' shell command still fails for large log entries
(shell/private/src/log_command.c:58 uses a 256 byte buffer and doesn't check for overflow).

> Logging can segfault for strings 512 characters or longer
> ---------------------------------------------------------
>                 Key: CELIX-198
>                 URL: https://issues.apache.org/jira/browse/CELIX-198
>             Project: Celix
>          Issue Type: Bug
>            Reporter: Daniel Parker
>            Assignee: Alexander Broekhuis
>             Fix For: next-incubating
> log_service/public/src/log_helper.c::logHelper_log() uses a buffer of 512 bytes and doesn't
check to make sure that the buffer is long enough to hold the input string.  The buffer should
be increased (or dynamic memory allocation used) and the sizes should be checked to prevent
overrun (perhaps by using vnsprintf() instead of vsprintf() ).

This message was sent by Atlassian JIRA

View raw message