Return-Path: X-Original-To: apmail-incubator-celix-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-celix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3635B107F7 for ; Thu, 19 Sep 2013 09:18:33 +0000 (UTC) Received: (qmail 38259 invoked by uid 500); 19 Sep 2013 09:18:32 -0000 Delivered-To: apmail-incubator-celix-commits-archive@incubator.apache.org Received: (qmail 38239 invoked by uid 500); 19 Sep 2013 09:18:32 -0000 Mailing-List: contact celix-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: celix-dev@incubator.apache.org Delivered-To: mailing list celix-commits@incubator.apache.org Received: (qmail 38231 invoked by uid 99); 19 Sep 2013 09:18:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Sep 2013 09:18:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Sep 2013 09:18:29 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 72EB92388900; Thu, 19 Sep 2013 09:18:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1524664 - /incubator/celix/trunk/shell_tui/private/src/shell_tui.c Date: Thu, 19 Sep 2013 09:18:09 -0000 To: celix-commits@incubator.apache.org From: abroekhuis@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20130919091809.72EB92388900@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: abroekhuis Date: Thu Sep 19 09:18:08 2013 New Revision: 1524664 URL: http://svn.apache.org/r1524664 Log: CELIX-85: Fixed an APR memory problem due to a thread not being stopped correctly. Modified: incubator/celix/trunk/shell_tui/private/src/shell_tui.c Modified: incubator/celix/trunk/shell_tui/private/src/shell_tui.c URL: http://svn.apache.org/viewvc/incubator/celix/trunk/shell_tui/private/src/shell_tui.c?rev=1524664&r1=1524663&r2=1524664&view=diff ============================================================================== --- incubator/celix/trunk/shell_tui/private/src/shell_tui.c (original) +++ incubator/celix/trunk/shell_tui/private/src/shell_tui.c Thu Sep 19 09:18:08 2013 @@ -144,11 +144,12 @@ celix_status_t bundleActivator_stop(void status = bundleContext_removeServiceListener(context, act->listener); if (status == CELIX_SUCCESS) { + apr_status_t join; free(act->listener); act->listener = NULL; act->context = NULL; act->running = false; - apr_thread_detach(act->runnable); + apr_thread_join(&join, act->runnable); } return status;