celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Broekhuis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CELIX-74) The serviceTrackerCustomizer header uses, but does not include, the serviceReference header.
Date Wed, 10 Jul 2013 12:35:49 GMT

    [ https://issues.apache.org/jira/browse/CELIX-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704503#comment-13704503
] 

Alexander Broekhuis commented on CELIX-74:
------------------------------------------

Hi,

This sounds like a bug, and is probably something that happens in more places. Ideally I think
each source files should include the headers it needs, it is irrelevant wether headers are
already include via other includes. This makes it more obvious what headers are used by a
certain piece of code, and also prevents problems like you are seeing.
Most logical reason for not noticing this before is indirect inclusion via other headers :).

For this case it is a simple and quick fix, I'll try to commit it somewhere today or tomorrow.
                
> The serviceTrackerCustomizer header uses, but does not include, the serviceReference
header.
> --------------------------------------------------------------------------------------------
>
>                 Key: CELIX-74
>                 URL: https://issues.apache.org/jira/browse/CELIX-74
>             Project: Celix
>          Issue Type: Bug
>            Reporter: Mike van Dongen
>            Priority: Critical
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The header file 'service_tracker_customizer.h' has references to the type service_reference_pt
but this type is not known.
> The header file 'service_reference.h' defines the type but is not included.
> This bug can be reproduced by simply including 'service_tracker_customizer.h' in an empty
project without other Celix includes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message