Mailing-List: contact user-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@cayenne.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-Id: <E74C0EF6-80C1-4472-8CA4-BF9A90DB70B9@objectstyle.org>
From: Andrus Adamchik <andrus@objectstyle.org>
To: user@cayenne.apache.org
In-Reply-To: <AANLkTin8J01vrHXpvAgu_LqACnxH2P788brAU5Acklc9@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: More on caching
Date: Fri, 28 May 2010 10:36:38 +0300
References: <AANLkTinNjW-ekdmmL7Vlxi39Qre04agg4LnbLXqs1HS4@mail.gmail.com>
 <92583F17-2CBA-45B5-9C5A-5F4FE81F9255@objectstyle.org>
 <AANLkTilajJMIHN2dwuXxygfqDIDmY-2gye8OcIB-mFWK@mail.gmail.com>
 <C537142F-04BC-4DCD-91FA-06E1C10C983F@objectstyle.org>
 <AANLkTin8J01vrHXpvAgu_LqACnxH2P788brAU5Acklc9@mail.gmail.com>

Ah that's right. A local query cache is created that belongs to this  
context only.

Not sure if we need to document it though. This is the internal  
details that are likely to change between releases.

Andrus

On May 28, 2010, at 10:17 AM, Gary Jarrel wrote:

> On Fri, May 28, 2010 at 4:43 PM, Andrus Adamchik <andrus@objectstyle.org 
> > wrote:
>>
>
>>> it seems that domain.getQueryCache().size() is returning 1
>>>
>>> assertEquals(1, ((DataContext)
>>> getDataContext()).getParentDataDomain().getQueryCache().size());
>>> assertEquals(1, ((DataContext)  
>>> getDataContext()).getQueryCache().size());
>>
>> I guess DataContext is assigned a different QueryCache instance  
>> somehow.
>>
>> Andrus
>>
>>
>
> I've just traced though the code and it seems that the queryCache
> member in DataContext never gets set. Cayenne uses the DataDomain
> query cache which is created on the first execution of my select
> query. The second select query also uses this cache. The call in the
> first assertEquals uses this cache is subsequently returns the correct
> result. However in the second assertEquals statement the method on
> line 226 of DataContext is executed.
>
> public QueryCache getQueryCache() {
>   if (queryCache == null) {
>       synchronized (this) {
>           if (queryCache == null) {
>
>               DataDomain domain = getParentDataDomain();
>               queryCache =  
> domain.getQueryCacheFactory().getQueryCache(
>                       domain.getProperties());
>           }
>       }
>   }
>
>   return queryCache;
> }
>
> At this point queryCache within the DataContext is still null so it
> goes of and creates another one hence the cache is empty.
>
> This could however be the correct behavior if the DataDomain holds the
> shared cache, while the data context holds the local cache, but if
> this is the case perhaps it needs to be documented a bit better?
>
> Cheers,
>
> Gary
>