Mailing-List: contact user-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@cayenne.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Mon, 17 Aug 2009 08:35:47 +0200
From: Jeremias Maerki <dev@jeremias-maerki.ch>
To: user@cayenne.apache.org
Subject: Re: Problem with reverse relationships and inheritance
In-Reply-To: <3219fff70908161301o6fa70637w692573b7452ec282@mail.gmail.com>
References: <20090814150854.62D0.60BA733C@jeremias-maerki.ch>
 <3219fff70908161301o6fa70637w692573b7452ec282@mail.gmail.com>
Message-Id: <20090817083009.6DF6.60BA733C@jeremias-maerki.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable

Thanks, Andrey. I somehow missed that. I'll see if I can allocate time
to write a test case. That could help speed things up.

On 16.08.2009 22:01:17 Andrey Razumovsky wrote:
> Hi Jeremias,
>=20
> This is also known as CAY-1009:
> http://issues.apache.org/jira/browse/CAY-1009
>=20
> I tried patch from there (and it looks like yours) but there WERE side
> effects (I listed them in JIRA). At the moment I was forced to make the
> relationship non-mandatory in my project (and validate in different ways).=
 I
> would really like to get it fixed, but I haven't found time for that yet...
> Please watch the JIRA to be notified of the updates
>=20
> Regards,
> Andrey
>=20
> 2009/8/14 Jeremias Maerki <dev@jeremias-maerki.ch>
>=20
> > I think I may have run into an issue that is related to this thread:
> > http://markmail.org/message/slm4joyswjp77vzi
> >
> > - I have an (abstract) entity A and two subentities/subclasses A1 and A=
2.
> > - I have an (abstract) entity B with three subentities B1, B2 and B3.
> > - There is a 1:n relationship from A to B.
> >
> > Now, if I create an instance of A1 and use addToB() to add a B1 instanc=
e,
> > B1 is added to the list. But I get a validation error because upon
> > commit the foreign key for the A1 instance is not set on the B1 instanc=
e.
> >
> > Debugging, I found that ObjRelationship.getReverseRelationship() didn't
> > look in super entities for the reverse relationship.
> >
> > Mindlessly changing that method (in Trunk) from:
> >
> >        Entity src =3D this.getSourceEntity();
> >
> >        Iterator<?> it =3D target.getRelationships().iterator();
> >        while (it.hasNext()) {
> >            ObjRelationship rel =3D (ObjRelationship) it.next();
> >            if (rel.getTargetEntity() !=3D src)
> >                continue;
> >
> > to:
> >
> >        Entity src =3D this.getSourceEntity();
> >
> >        Iterator<?> it =3D target.getRelationships().iterator();
> >        while (it.hasNext()) {
> >            ObjRelationship rel =3D (ObjRelationship) it.next();
> >            Entity relTarget =3D rel.getTargetEntity();
> >            ObjEntity currentSrc =3D (ObjEntity)src;
> >            while (currentSrc !=3D null) {
> >                if (relTarget =3D=3D currentSrc) {
> >                    break;
> >                }
> >                currentSrc =3D currentSrc.getSuperEntity();
> >            }
> >            if (src =3D=3D null) {
> >                continue;
> >            }
> >
> > ...solves my immediate problem, but I have no idea about any
> > side-effects. Am I doing anything wrong?
> >
> > Thanks,
> > Jeremias Maerki
> >
> >


Jeremias Maerki