From dev-return-11166-archive-asf-public=cust-asf.ponee.io@cayenne.apache.org Fri Apr 3 15:57:23 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90F4F18064F for ; Fri, 3 Apr 2020 17:57:23 +0200 (CEST) Received: (qmail 19098 invoked by uid 500); 3 Apr 2020 15:57:22 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 19085 invoked by uid 99); 3 Apr 2020 15:57:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2020 15:57:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D8726C07B1 for ; Fri, 3 Apr 2020 15:57:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id DOmKWc5tD11Q for ; Fri, 3 Apr 2020 15:57:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.208.176; helo=mail-lj1-f176.google.com; envelope-from=johnthuss@gmail.com; receiver= Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id EAE2CBB87E for ; Fri, 3 Apr 2020 15:57:19 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id i20so7447976ljn.6 for ; Fri, 03 Apr 2020 08:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=PnAhXSFVuqpPiGqOk4ITm0QPs5M0za986aVkiVz1b1s=; b=aqBBEWhr2sE7M4jPgFv9hSxiuguVPSrawsi8TbVS3ar5nu+hIa/8S68u0hwzqiiDge yHCc7G65cWTXHZ6+ST7WoUj3lEG9JiMwxFW7TVj7KmOGNHhohuNe0rDRsM/fX2htN7O6 hDh9hJ8dhpZBu09JY+NgC+3n5P/7a7GB4uRfYdqZcwwP+ipQNWEfVUzNAYlLwp3cVF6g yUG/+U64t1h2Os+wUBrh39KrlLkJZJQwsaBGhNedeTViIXvFoiE09kHVt1wadT2Cf0rj PoYha4zzHqheSYrz/PN1ef4QeUpr+oFS7b0NhjeLrACqEWv85y1336dJKs4fUe6lkHE1 SR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=PnAhXSFVuqpPiGqOk4ITm0QPs5M0za986aVkiVz1b1s=; b=k98147uZtV9IgFBC1elbnw9XrhugJ0+pk6mSM2tNBuOS1gMYz8E8ZYmQOV3UcNSy+B BDMKixjk8mDSBnWDncCEq0po0ZJrLU4d6h5b4d8PMyPWUZnAcLYHf/rw45CX0OTJqOsf jrOldm6LsyS8jjudN1wJzQgZofFNyyx7PYmzbQe1hV2BYZWtQDlHACTFJw5AVwadxq2R MstfCRADTDzuInHNyOpUMUzyeoqRQKSKxCkvZ+bCWmO0U4rDe0iylw20EvrCCnYiFc0l NSd532AuMQcZUPoJ+tX4P3wm3HUpXtyhDRDPVsXOZFpKb/bN1eLf0h5GaNyJDZcXMiT9 Ps6g== X-Gm-Message-State: AGi0PuY3UdT7xDV6x8pvYYDG0O3F4NojK6iMKbv61RnD+PaBJiup9MO1 SpyZdA+9WrGcJaHNKcziE7SsrBH7nLEiI44usOyMKw== X-Google-Smtp-Source: APiQypJCndVkU0l89MAdpePr9J98SsUwrmZ9dniqLhzrwMjK/oPm96X3WPeUs0wZK2uaGzhxO51B9oY3Qw6EF0POzUE= X-Received: by 2002:a2e:954e:: with SMTP id t14mr4896552ljh.253.1585929432306; Fri, 03 Apr 2020 08:57:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: John Huss Date: Fri, 3 Apr 2020 10:56:56 -0500 Message-ID: Subject: Re: [VOTE] Apache Cayenne 4.2.M1 release To: dev@cayenne.apache.org Content-Type: multipart/alternative; boundary="00000000000073980305a264f80b" --00000000000073980305a264f80b Content-Type: text/plain; charset="UTF-8" Thanks, that issue appears to be fixed now! On Fri, Apr 3, 2020 at 6:57 AM Nikita Timofeev wrote: > Hi all, > > I've rolled back 4.2.M1 release and will start new voting soon. > Fix for the meaningful FK is committed now [1]. > I've also checked that the latest snapshot version of the Apache RAT > [2] is ok with the "https://", so we could use it. > I'll update docs and also will mention the maven plugin. > > John, could you please check again your meaningful FK test case with > the latest cayenne snapshot build? > > [1] https://issues.apache.org/jira/browse/CAY-2652 > [2] > https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/ > > On Sat, Mar 28, 2020 at 1:04 AM John Huss wrote: > > > > Thanks. > > > > I figured out the problem with cgen was that I had > velocity-engine-core-2.0 > > instead of velocity-engine-core-2.1. Updating the jar fixed the problem. > > > > > > On Thu, Mar 26, 2020 at 12:25 PM Nikita Timofeev < > ntimofeev@objectstyle.com> > > wrote: > > > > > Thank you, John, for your thorough testing. > > > > > > 1. Seems like RAT don't like the change from "http://" to "https://" > > > in the license text. I've updated settings for the RAT maven plugin > > > (as I use it to check sources) and that works ok. Need to update > > > config for the standalone script. > > > 2. Cgen + ant. IIRC we had some problems with that and you helped a > > > lot with it. I've tested cgen task in a simple demo project and it > > > works fine for me, but I don't really know much about the Ant. > > > If you can create a demo project or help somehow else, that would be > great. > > > 3. I was able to reproduce this one. Primitive type in the meaningful > > > FK really creating problems, so need to fix this. > > > > > > I'll keep this vote open in case something else comes up. > > > > > > On Thu, Mar 26, 2020 at 1:05 AM John Huss wrote: > > > > > > > > Thanks for all your work on this. 4.2 is going to be a great > release! I > > > ran > > > > all my checks on the release and almost everything passed. > > > > > > > > I don't know what changed, but I'm having a RAT problem I haven't > seen > > > > before. RAT (both 0.12 and 0.13) show this header: > > > > > > > > Printing headers for text files without a valid license header... > > > > > > > > > > > > then lists basically every source file in the archive, example below. > > > When > > > > I open this file directly the license header is there, but the > printout > > > > from RAT doesn't show it. > > > > > > > > ===================================================== > > > > > > > > == File: > > > > > > > > cayenne-4.2.M1-src/cayenne-osgi/src/test/java/org/apache/cayenne/configuration/osgi/OsgiClassLoaderManagerTest.java > > > > > > > > ===================================================== > > > > > > > > /***************************************************************** > > > > > > > > * > > > > > > > > * > > > > > > > > ****************************************************************/ > > > > > > > > package org.apache.cayenne.configuration.osgi; > > > > > > > > > > > > import org.junit.Test; > > > > > > > > > > > > import java.util.Collections; > > > > > > > > > > > > import static org.junit.Assert.assertSame; > > > > > > > > import static org.mockito.Mockito.mock; > > > > > > > > > > > > public class OsgiClassLoaderManagerTest { > > > > > > > > > > > > > > > > > > > > ----------------------------------------------------------------------------------------------------------------------------- > > > > More importantly, I'm seeing some issues with cgen (using ant) not > > > finding > > > > templates. This wasn't happening when I tested 4.2 months ago, so it > must > > > > be a more recent change. > > > > > > > > org.apache.velocity.exception.ResourceNotFoundException: Unable to > find > > > > resource 'templates/v4_1/superclass.vm' > > > > > > > > > > > > > > > > > > > > > > > > > > > superpkg="com.myapp.auto" > > > > > > > > createpropertynames="true" > > > > > > > > destDir="src" > > > > > > > > outputPattern="*.java" > > > > > > > > usepkgpath="true" > > > > > > > > encoding="UTF-8" > > > > > > > > mode="all" > > > > > > > > force="true" > > > > > > > > /> > > > > > > > > > > > > > > > > > > > > > > > > The unit tests in my projects are looking nearly perfect. But I did > see a > > > > regression in a very specific case. I have an entity with a > meaningful > > > > foreign key attribute that is modeled as a primitive (int). The > attribute > > > > is the same column as referenced by a relationship on the same > entity. > > > This > > > > was working in the previous version but isn't working now. The value > is > > > > just always zero for this field now. I'm not sure if this is > supposed to > > > be > > > > supported. > > > > > > > > > > > > On Tue, Mar 24, 2020 at 4:55 AM Nikita Timofeev < > > > ntimofeev@objectstyle.com> > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > Here is a long-awaited 4.2.M1 release. > > > > > JIRA tells that it has impressive 100 issues resolved. > > > > > > > > > > Release notes: > > > > > https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt > > > > > Maven repo: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecayenne-1037/ > > > > > Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.2.M1/ > > > > > > > > > > Please evaluate and cast your votes. > > > > > > > > > > -- > > > > > Best regards, > > > > > Nikita Timofeev > > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Nikita Timofeev > > > > > > > -- > Best regards, > Nikita Timofeev > --00000000000073980305a264f80b--