cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aristedes Maniatis <...@maniatis.org>
Subject Re: Renaming cayenne-postcommit module to cayenne-commitlog
Date Wed, 17 May 2017 11:40:58 GMT
I accidentally replied just to Nikita, so bringing this back to the list. I think if it is
that specific, then the naming is a great idea.

Ari

On 17/5/17 9:38pm, Nikita Timofeev wrote:
> Hi Ari,
> 
> This module is providing access to cayenne's commit log in a form that can be easily
processed.
> So you can use it for whatever you can imagine,
> thought most obvious usage is some sort of audit logging.
> 
> Postcommit module was there for some time as part of cayenne-lifecycle, created to replace
Audit filter.
> My change is only about pulling it out(that's done already) and renaming it.
> 
> Wednesday, 17 May 2017, 02:05pm +03:00 from Aristedes Maniatis ari@maniatis.org:
>>On 17/5/17 5:43pm, Nikita Timofeev wrote:
>>> Hi all,
>>>
>>> There is a pull request from me for the subj.
>>> It has some braking changes (for feature introduced in 4.0 though)
>>> and I want to have some feedback before I can apply it.
>>> Details can be found in PR [1] or in Jira [2].
>>>
>>> In short the idea is to give "postcommit" functionality name that is better
>>> describe it, as "postcommit" is obscure and clashes with POST_COMMIT
>>> callback that is a completely separate feature.
>>>
>>> [1] https://github.com/apache/cayenne/pull/214
>>> [2] https://issues.apache.org/jira/browse/CAY-2302
>>Can this module be used for things which aren't just logging?
>>Ari
>>--
>>-------------------------->
>>Aristedes Maniatis
>>GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A
> 


-- 
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A

Mime
View raw message