cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrus Adamchik <and...@objectstyle.org>
Subject Re: Travis errors, Was: 4.0 jenkins build failures
Date Wed, 30 Nov 2016 11:19:23 GMT
BTW, we have a working Travis patch courtesy of https://github.com/IRus :

https://github.com/apache/cayenne/pull/145

Planning to apply this tonight.

Andrus

> On May 24, 2016, at 3:05 PM, Andrus Adamchik <andrus@objectstyle.org> wrote:
> 
>> <dependency>
>>   <groupId>log4j</groupId>
>>   <artifactId>log4j</artifactId>
>>   <version>1.2.17</version>
>>   <scope>test</scope>
>> </dependency>
> 
> 
> If we are to use Log4J, let's at least use Log4J2 [1]. Also you will likely need log4j-jcl.jar
bridge [2].
> 
>> And provided commons-logging.properties
> 
> Not sure what you placed in there, but I think with the bridge, you won't need this file.
> 
> Andrus
> 
> [1] http://search.maven.org/#search|ga|1|log4j2
> [2] https://logging.apache.org/log4j/2.x/faq.html#which_jars
> 
> 
>> On May 24, 2016, at 2:34 PM, Savva Kolbachev <s.kolbachev@gmail.com> wrote:
>> 
>>> Are we using Log4J bridge to commons-logging?
>> If I understand correctly, we are using slf4j. We have the following
>> dependencies:
>> 
>> <dependency>
>>     <groupId>org.slf4j</groupId>
>>     <artifactId>jcl-over-slf4j</artifactId>
>>     <scope>test</scope>
>> </dependency>
>> <dependency>
>>     <groupId>org.slf4j</groupId>
>>     <artifactId>slf4j-api</artifactId>
>>     <scope>test</scope>
>> </dependency>
>> <dependency>
>>     <groupId>org.slf4j</groupId>
>>     <artifactId>slf4j-simple</artifactId>
>>     <scope>test</scope>
>> </dependency>
>> 
>> So, I just replaced them with this one:
>> <dependency>
>>   <groupId>log4j</groupId>
>>   <artifactId>log4j</artifactId>
>>   <version>1.2.17</version>
>>   <scope>test</scope>
>> </dependency>
>> 
>> And provided commons-logging.properties and log4j.properties files. I
>> tested it with cayenne-client module, but it shouldn't be a problem to
>> apply for the whole project.
>> 
>> 2016-05-24 14:15 GMT+03:00 Andrus Adamchik <andrus@objectstyle.org>:
>> 
>>> 
>>>> For the purposes of running tests I think it really doesn't matter much
>>> 
>>> Of course.
>>> 
>>>> if Savva already has log4j working, then let's just do that.
>>> 
>>> Are we using Log4J bridge to commons-logging?
>>> 
>>> Andrus
>>> 
>>>> On May 24, 2016, at 2:11 PM, Aristedes Maniatis <ari@maniatis.org>
>>> wrote:
>>>> 
>>>> For the purposes of running tests I think it really doesn't matter much
>>> and if Savva already has log4j working, then let's just do that. The only
>>> goal here is to fix Travis and that's only so we can get access to some
>>> additional databases they make available:
>>> https://docs.travis-ci.com/user/database-setup/
>>>> 
>>>> Ari
>>>> 
>>>> 
>>>> On 24/05/2016 8:52pm, Andrus Adamchik wrote:
>>>>> Yeah, whichever way we bridge commons-logging, we need to do it. There
>>> are two things to consider:
>>>>> 
>>>>> 1. logging API used in the code (Cayenne core uses common-logging).
>>>>> 2. logging implementation that bridges #1 and writes the logs out.
>>> Choices are: Logback, Log4J, slf4j-simple. The first two are configurable
>>> via properties.
>>>>> 
>>>>> I have no preference as to #2. There may be some slight benefit in
>>> switching #1 to SLF, but this is a different discussion.
>>>>> 
>>>>> Andrus
>>>>> 
>>>>>> On May 24, 2016, at 1:32 PM, Savva Kolbachev <s.kolbachev@gmail.com>
>>> wrote:
>>>>>> 
>>>>>> I don't know a lot about loggers, but I've tried to use the old log4j
>>>>>> http://mvnrepository.com/artifact/log4j/log4j/1.2.17 instead of slf4j
>>> in
>>>>>> the test scope and it works. I could handle the behavior
>>>>>> via commons-logging.properties and log4j.properties files.
>>>>>> 
>>>>>> So, how about to move from slf4j to log4j for test purposes?
>>>>>> 
>>>>>> 
>>>>>> 2016-04-18 9:43 GMT+03:00 Aristedes Maniatis <ari@maniatis.org>:
>>>>>> 
>>>>>>> On 18/04/2016 4:27pm, Andrus Adamchik wrote:
>>>>>>>> "mvn -q" suppresses Maven's own logging.
>>>>>>> 
>>>>>>> We've already got that, but it doesn't stop much.
>>>>>>> 
>>>>>>>> This leaves Cayenne's logging. To control that, we need to
provide
>>>>>>> proper logging dependencies in the "test" scope. E.g. add
>>>>>>> SLF4J-to-commons-loging bridge and Logback jars, and then configure
>>> Logback
>>>>>>> to use a minimal prefix for each log line.
>>>>>>> 
>>>>>>> I was proceeding on the assumption that commons-logging sends
to the
>>>>>>> default Java logger when nothing else is configured. Perhaps
you are
>>> right
>>>>>>> and we add log4j or slf4j to the test dependencies and then try
to
>>> silence
>>>>>>> that.
>>>>>>> 
>>>>>>> Ari
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> -------------------------->
>>>>>>> Aristedes Maniatis
>>>>>>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49
102A
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Thanks and Regards
>>>>>> Savva Kolbachev
>>>>> 
>>>> 
>>>> --
>>>> -------------------------->
>>>> Aristedes Maniatis
>>>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A
>>> 
>>> 
>> 
>> 
>> -- 
>> Thanks and Regards
>> Savva Kolbachev
> 


Mime
View raw message