Return-Path: X-Original-To: apmail-cayenne-dev-archive@www.apache.org Delivered-To: apmail-cayenne-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A21321988E for ; Tue, 5 Apr 2016 11:24:56 +0000 (UTC) Received: (qmail 82294 invoked by uid 500); 5 Apr 2016 11:24:56 -0000 Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org Received: (qmail 82268 invoked by uid 500); 5 Apr 2016 11:24:56 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 82257 invoked by uid 99); 5 Apr 2016 11:24:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 11:24:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C9E77C3713 for ; Tue, 5 Apr 2016 11:24:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.28 X-Spam-Level: X-Spam-Status: No, score=0.28 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7fiTSwYTNSrj for ; Tue, 5 Apr 2016 11:24:53 +0000 (UTC) Received: from mail16.tpgi.com.au (mail16.tpgi.com.au [203.12.160.231]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id AD6255F54E for ; Tue, 5 Apr 2016 11:24:52 +0000 (UTC) X-TPG-Junk-Status: Message not scanned X-TPG-Antivirus: Passed X-TPG-Abuse: host=[202.161.115.54]; ip=202.161.115.54; date=Tue, 5 Apr 2016 21:24:42 +1000 Received: from fish.ish.com.au (202-161-115-54.static.tpgi.com.au [202.161.115.54] (may be forged)) by mail16.tpgi.com.au (envelope-from prvs=09035517ba=ari@maniatis.org) (8.14.3/8.14.3) with ESMTP id u35BOe2W023968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 5 Apr 2016 21:24:42 +1000 Received: from [10.242.2.34] (port=50892 helo=Aristedess-MacBook-Pro.local) by fish.ish.com.au with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1anP63-0000Uf-0H for dev@cayenne.apache.org; Tue, 05 Apr 2016 21:24:35 +1000 X-CTCH-RefID: str=0001.0A150206.5703A073.0128,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 To: dev@cayenne.apache.org From: Aristedes Maniatis Subject: merging process Message-ID: <8c0497cf-c71f-88a9-27a7-4692d9d4ce45@maniatis.org> Date: Tue, 5 Apr 2016 21:24:35 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Can we discuss the process by which https://github.com/apache/cayenne/pull/94 got merged just now? I'm confused about who is the asfgit user is who "merged" this to master. Also, what is our process for handling CLA from github users. And as for the commit itself: it has problems. Firstly the javadocs are wrong on one method and missing on the other. And I'm not sure why we'd be adding static methods to this class. That just seems like unnecessary clutter. Ari -- --------------------------> Aristedes Maniatis GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A