Return-Path: X-Original-To: apmail-cayenne-dev-archive@www.apache.org Delivered-To: apmail-cayenne-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6F2D189AB for ; Fri, 12 Feb 2016 09:43:45 +0000 (UTC) Received: (qmail 26505 invoked by uid 500); 12 Feb 2016 09:43:45 -0000 Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org Received: (qmail 26477 invoked by uid 500); 12 Feb 2016 09:43:45 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 26466 invoked by uid 99); 12 Feb 2016 09:43:45 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 09:43:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 148F0C1BF2 for ; Fri, 12 Feb 2016 09:43:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.28 X-Spam-Level: X-Spam-Status: No, score=0.28 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Nud0ugLFpV5n for ; Fri, 12 Feb 2016 09:43:44 +0000 (UTC) Received: from mail16.tpgi.com.au (mail16.tpgi.com.au [203.12.160.231]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id B926920D31 for ; Fri, 12 Feb 2016 09:43:43 +0000 (UTC) X-TPG-Junk-Status: Message not scanned X-TPG-Antivirus: Passed X-TPG-Abuse: host=[202.161.115.54]; ip=202.161.115.54; date=Fri, 12 Feb 2016 20:43:41 +1100 Received: from fish.ish.com.au (202-161-115-54.static.tpgi.com.au [202.161.115.54] (may be forged)) by mail16.tpgi.com.au (envelope-from ari@maniatis.org) (8.14.3/8.14.3) with ESMTP id u1C9heps013984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 12 Feb 2016 20:43:41 +1100 Received: from [10.242.2.22] (port=59155 helo=Aristedess-MacBook-Pro.local) by fish.ish.com.au with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1aUAGI-0007Oi-1S for dev@cayenne.apache.org; Fri, 12 Feb 2016 20:43:38 +1100 X-CTCH-RefID: str=0001.0A150208.56BDA94A.0241,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: work on ROP To: dev@cayenne.apache.org References: <56713B2C.40601@ish.com.au> <24A23A99-B53D-497A-8BEA-B5F40070620C@objectstyle.org> <5671BF35.5060809@gmail.com> <12DCC748-C737-4B55-896F-0CE0C4B09037@objectstyle.org> <56726314.2060205@maniatis.org> <7EABB636-0EDE-4C38-9576-5959D81E1370@objectstyle.org> <1656662F-5CEC-4C7E-806A-9D247F688109@objectstyle.org> <5673D335.3040607@maniatis.org> <569FB76E.40900@gmail.com> <56A0AFCD.5070905@maniatis.org> <56A0D189.2060903@gmail.com> From: Aristedes Maniatis Message-ID: <56BDA949.7030605@maniatis.org> Date: Fri, 12 Feb 2016 20:43:37 +1100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <56A0D189.2060903@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 21/01/2016 11:39pm, Dzmitry Kazimirchyk wrote: >> BaseConnection.sendMessage(message) does pretty much nothing but call beforeSendMessage(message), then doSendMessage(message) with a bunch of logging. It all seems a bit pointless. >> > > True. Before my changes it also used to store readTimeout value, but now all it does is logging, which can be moved a level down to the actual ClientConnection implementation. Right, let's do this bit. Ari -- --------------------------> Aristedes Maniatis GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A