cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrus Adamchik <and...@objectstyle.org>
Subject Re: work on ROP
Date Wed, 17 Feb 2016 06:26:25 GMT
+1

> On Feb 17, 2016, at 1:56 AM, Aristedes Maniatis <ari@maniatis.org> wrote:
> 
> On 12/02/2016 8:43pm, Aristedes Maniatis wrote:
>> On 21/01/2016 11:39pm, Dzmitry Kazimirchyk wrote:
>>>> BaseConnection.sendMessage(message) does pretty much nothing but call beforeSendMessage(message),
then doSendMessage(message) with a bunch of logging. It all seems a bit pointless.
>>>> 
>>> 
>>> True. Before my changes it also used to store readTimeout value, but now all
it does is logging, which can be moved a level down to the actual ClientConnection implementation.
>> 
>> Right, let's do this bit.
>> 
>> Ari
>> 
> 
> 
> So this work doesn't get lost, is everyone happy that we merge it now into master?
> 
> Ari
> 
> 
> 
> -- 
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A


Mime
View raw message