Return-Path: X-Original-To: apmail-cayenne-dev-archive@www.apache.org Delivered-To: apmail-cayenne-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 30E1C184B0 for ; Mon, 12 Oct 2015 16:57:11 +0000 (UTC) Received: (qmail 44768 invoked by uid 500); 12 Oct 2015 16:56:58 -0000 Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org Received: (qmail 44742 invoked by uid 500); 12 Oct 2015 16:56:58 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 44439 invoked by uid 99); 12 Oct 2015 16:56:58 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 16:56:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 560B4C2AE2 for ; Mon, 12 Oct 2015 16:56:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.1 X-Spam-Level: X-Spam-Status: No, score=-0.1 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zRbISFYYtNZB for ; Mon, 12 Oct 2015 16:56:49 +0000 (UTC) Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 6061F20524 for ; Mon, 12 Oct 2015 16:56:48 +0000 (UTC) Received: by qkht68 with SMTP id t68so60238708qkh.3 for ; Mon, 12 Oct 2015 09:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=pxPaEGd/DNU4WP1zvc9FP4VpAYsJW9UZDr87U6ouzuQ=; b=kX/6RxCvy0y22BCXK9OPpFivctzMK+fYCDhcpJIzJ1PY3Y3v0Zqq5tor3QxpJbbjvQ CZhozE2g7AWpK/6HH/OxhUBjlvp6J1/AVCvQjiLywShcL5xi8eX56S2DlUf3ElYz9Djm auhYIHJNxhAv30FWo0Z9EJfL3HoJYuu/Jj5xT2fEazIso153v/JIJcRYcIbtICkLOg+6 TB1GP2kr5reGlinOIaNvIFOhghDwFvU2nhw5PDHI0Vn5l2C3nET+PVfNvDa4gap1BJRT HP1KN3ilPu/NFVn2vIqy8C5r02UTmeWHD80D5D3lp8YG1owDMHTxBQe8V9956xIFyrkH r0tg== X-Received: by 10.55.212.77 with SMTP id l74mr33125729qki.19.1444669007398; Mon, 12 Oct 2015 09:56:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.41.202 with HTTP; Mon, 12 Oct 2015 09:56:28 -0700 (PDT) In-Reply-To: <56F4A1D6-8CA3-4270-B466-C8393FC04331@objectstyle.org> References: <56F4A1D6-8CA3-4270-B466-C8393FC04331@objectstyle.org> From: Mike Kienenberger Date: Mon, 12 Oct 2015 12:56:28 -0400 Message-ID: Subject: Re: CayenneModeler not generating classes To: dev@cayenne.apache.org Content-Type: text/plain; charset=UTF-8 Even if these lines are right, they are using undocumented velocity behavior -- I could find no reference to allowing multi-line #if statements nor allowing "and" and "or" as logical expressions in the velocity documents. On Mon, Oct 12, 2015 at 12:51 PM, Andrus Adamchik wrote: > [taking to dev] > > @Savva : these were checked in on April 29th per CAY-1999. Could you please check whether we need to make this change in the Cayenne code? (and perhaps we can reproduce the issue with a unit test). > > Thanks, > Andrus > >> On Oct 12, 2015, at 12:33 PM, Mike Kienenberger wrote: >> >> I haven't had time to test this yet, but I'm pretty sure that lines 38 >> & 39 in the template are wrong. >> >> Dipesh, >> >> Go to https://github.com/apache/cayenne/blob/master/cayenne-tools/src/main/resources/templates/v1_2/superclass.vm >> in your checkout, and replace lines 38 and 39 with a single line 38 >> containing: >> >> #if((${object.DeclaredAttributes} && >> !${object.DeclaredAttributes.isEmpty()}) || >> (${object.DeclaredRelationships} && >> !${object.DeclaredRelationships.isEmpty()})) >