cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Huss <johnth...@gmail.com>
Subject Re: ExtendedTypes for Joda
Date Thu, 30 Apr 2015 17:02:00 GMT
Works for me.  Can you make the changes Savva?

On Thu, Apr 30, 2015 at 5:30 AM Savva Kolbachev <s.kolbachev@gmail.com>
wrote:

> I would like to apply John Huss's code from CAY-1626 as separate module.
> It's something like I've already made in
> https://github.com/apache/cayenne/pull/41 for Java8 time. With one
> exception: users need to add another maven dependency.
>
> 2015-04-30 9:13 GMT+03:00 Andrus Adamchik <andrus@objectstyle.org>:
>
> > Taking this to dev.
> >
> > I am +1 on the Joda support inclusion in general. Coincidentally we
> talked
> > with Savva yesterday about this in the context of another Jira. What we
> > need to do here though is prevent making Joda a mandatory dependency of
> > Cayenne, while making bootstrap easy.
> >
> > Savva suggested making a separate Maven (and DI) module that is included
> > in Cayenne explicitly on startup and that loads all the Joda types at
> once.
> > I see the patch has 'registerWithRuntime' per type. A DI module is an
> > improvement on that (and is similar to how other extensions work -
> crypto,
> > osgi, etc.)
> >
> > Andrus
> >
> > > On Apr 30, 2015, at 12:50 AM, John Huss (JIRA) <jira@apache.org>
> wrote:
> > >
> > >
> > >    [
> >
> https://issues.apache.org/jira/browse/CAY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520340#comment-14520340
> > ]
> > >
> > > John Huss commented on CAY-1626:
> > > --------------------------------
> > >
> > > This has been outstanding for a long time.  Any objections to merging
> it
> > after rebasing it on master?
> > >
> > > Since Java 8 support is still a ways out and many people (me) have
> > existing code using joda-time this is still a useful feature.
> > >
> > >> Add JodaTime DateTime support
> > >> -----------------------------
> > >>
> > >>                Key: CAY-1626
> > >>                URL: https://issues.apache.org/jira/browse/CAY-1626
> > >>            Project: Cayenne
> > >>         Issue Type: Improvement
> > >>         Components: Database integration
> > >>   Affects Versions: 3.1M2
> > >>           Reporter: Marc O'Morain
> > >>        Attachments: 0001-Add-support-for-joda-time-attributes.patch,
> > 0002-Add-support-for-joda-time-attributes.patch,
> > 0003-CAY-1626-Add-JodaTime-DateTime-support.patch, DateTimeType.java,
> > joda-patch.txt
> > >>
> > >>
> > >> Here is some code that we wrote at Swrve to load/save jodatime
> DateTime
> > objects with Cayenne
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian JIRA
> > > (v6.3.4#6332)
> > >
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message