cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Gentry <mgen...@masslight.net>
Subject Re: [17/17] cayenne git commit: Merge remote-tracking branch 'apache/master'
Date Fri, 24 Apr 2015 13:24:23 GMT
No rush, Alex.  :-)

One of the limitations of building a framework is we can't rely on nice
things like Apache Commons because we don't want to introduce
version/dependency conflicts in applications that use Cayenne.  (I know
I've wanted to plug in a few StringUtils calls several times.)

Thanks,

mrg


On Fri, Apr 24, 2015 at 9:10 AM, Alex Kolonitsky <
akolonitsky@objectstyle.com> wrote:

> I will remove this dependency today.
>
> > On Apr 24, 2015, at 3:27 PM, Michael Gentry <mgentry@masslight.net>
> wrote:
> >
> > Looks like org.apache.commons.lang3.tuple.Pair is used in multiple places
> > now, such as in DbLoader:
> >
> > -    public Map<DbEntity, PatternFilter> getTables(DbLoaderConfiguration
> > config, String[] types)
> > +    public Map<Pair<String, String>, Map<String, Pair<DbEntity,
> > PatternFilter>>> getTables(DbLoaderConfiguration config, String[] types)
> >
> > mrg
> >
> >
> > On Fri, Apr 24, 2015 at 3:52 AM, Andrus Adamchik <andrus@objectstyle.org
> >
> > wrote:
> >
> >> Alex, this change looks suspect. Was it intentional?
> >>
> >>
> >>> On Apr 24, 2015, at 1:13 AM, kolonitsky@apache.org wrote:
> >>>
> >>>
> >>
> http://git-wip-us.apache.org/repos/asf/cayenne/blob/09c6da92/cayenne-server/pom.xml
> >>> ----------------------------------------------------------------------
> >>> diff --git a/cayenne-server/pom.xml b/cayenne-server/pom.xml
> >>> index d00cd8c..ee4e3c7 100644
> >>> --- a/cayenne-server/pom.xml
> >>> +++ b/cayenne-server/pom.xml
> >>> @@ -48,6 +48,11 @@
> >>>                      <artifactId>commons-logging</artifactId>
> >>>                      <scope>compile</scope>
> >>>              </dependency>
> >>> +        <dependency>
> >>> +            <groupId>org.apache.commons</groupId>
> >>> +            <artifactId>commons-lang3</artifactId>
> >>> +            <version>3.0</version>
> >>> +        </dependency>
> >>>              <dependency>
> >>>                      <groupId>org.apache.velocity</groupId>
> >>>                      <artifactId>velocity</artifactId>
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message