Return-Path: 
 <dev-return-9139-apmail-cayenne-dev-archive=cayenne.apache.org@cayenne.apache.org>
X-Original-To: apmail-cayenne-dev-archive@www.apache.org
Delivered-To: apmail-cayenne-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5948710986
	for <apmail-cayenne-dev-archive@www.apache.org>;
 Thu,  1 Aug 2013 17:21:55 +0000 (UTC)
Received: (qmail 55896 invoked by uid 500); 1 Aug 2013 17:21:55 -0000
Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org
Received: (qmail 55442 invoked by uid 500); 1 Aug 2013 17:21:51 -0000
Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cayenne.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cayenne.apache.org>
List-Post: <mailto:dev@cayenne.apache.org>
List-Id: <dev.cayenne.apache.org>
Reply-To: dev@cayenne.apache.org
Delivered-To: mailing list dev@cayenne.apache.org
Received: (qmail 55028 invoked by uid 99); 1 Aug 2013 17:21:49 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2013 17:21:49 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [208.78.103.231] (HELO vorsha.objectstyle.org) (208.78.103.231)
    by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 Aug 2013 17:21:44 +0000
Received: (qmail 8641 invoked from network); 1 Aug 2013 17:26:27 -0000
Received: from unknown (HELO ?IPv6:::1?) (127.0.0.1)
  by localhost with SMTP; 1 Aug 2013 17:26:27 -0000
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: svn commit: r1509274 -
 /cayenne/main/trunk/framework/cayenne-core-unpublished/src/main/java/org/apache/cayenne/query/SelectQuery.java
From: Andrus Adamchik <andrus@objectstyle.org>
In-Reply-To: <20130801150333.A3B6A23888E2@eris.apache.org>
Date: Thu, 1 Aug 2013 20:21:23 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <2C121BBE-648B-43B6-B7E3-807F1AA3FE09@objectstyle.org>
References: <20130801150333.A3B6A23888E2@eris.apache.org>
To: dev@cayenne.apache.org
X-Mailer: Apple Mail (2.1508)
X-Virus-Checked: Checked by ClamAV on apache.org

Not that I have any objections, but I am wondering what good does it do =
for you to subclass Ordering?

Andrus


On Aug 1, 2013, at 6:03 PM, johnthuss@apache.org wrote:

> Author: johnthuss
> Date: Thu Aug  1 15:03:33 2013
> New Revision: 1509274
>=20
> URL: http://svn.apache.org/r1509274
> Log:
> Allow an Ordering subclass to be used where Ordering is accepted
>=20
> Modified:
>    =
cayenne/main/trunk/framework/cayenne-core-unpublished/src/main/java/org/ap=
ache/cayenne/query/SelectQuery.java
>=20
> Modified: =
cayenne/main/trunk/framework/cayenne-core-unpublished/src/main/java/org/ap=
ache/cayenne/query/SelectQuery.java
> URL: =
http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-core-unp=
ublished/src/main/java/org/apache/cayenne/query/SelectQuery.java?rev=3D150=
9274&r1=3D1509273&r2=3D1509274&view=3Ddiff
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- =
cayenne/main/trunk/framework/cayenne-core-unpublished/src/main/java/org/ap=
ache/cayenne/query/SelectQuery.java (original)
> +++ =
cayenne/main/trunk/framework/cayenne-core-unpublished/src/main/java/org/ap=
ache/cayenne/query/SelectQuery.java Thu Aug  1 15:03:33 2013
> @@ -91,7 +91,7 @@ public class SelectQuery<T> extends Qual
>      *=20
>      * @since 3.2
>      */
> -    public static <T> SelectQuery<T> query(Class<T> rootClass, =
Expression qualifier, List<Ordering> orderings) {
> +    public static <T> SelectQuery<T> query(Class<T> rootClass, =
Expression qualifier, List<? extends Ordering> orderings) {
>         return new SelectQuery<T>(rootClass, qualifier, orderings);
>     }
>=20
> @@ -173,7 +173,7 @@ public class SelectQuery<T> extends Qual
>      *            defines how to order the results, may be null.
>      * @since 3.1
>      */
> -    public SelectQuery(ObjEntity root, Expression qualifier, =
List<Ordering> orderings) {
> +    public SelectQuery(ObjEntity root, Expression qualifier, List<? =
extends Ordering> orderings) {
>         this();
>         this.init(root, qualifier);
>         addOrderings(orderings);
> @@ -215,7 +215,7 @@ public class SelectQuery<T> extends Qual
>      *            defines how to order the results, may be null.
>      * @since 3.1
>      */
> -    public SelectQuery(Class<T> rootClass, Expression qualifier, =
List<Ordering> orderings) {
> +    public SelectQuery(Class<T> rootClass, Expression qualifier, =
List<? extends Ordering> orderings) {
>         init(rootClass, qualifier);
>         addOrderings(orderings);
>     }
> @@ -257,7 +257,7 @@ public class SelectQuery<T> extends Qual
>      *            defines how to order the results, may be null.
>      * @since 3.1
>      */
> -    public SelectQuery(DbEntity root, Expression qualifier, =
List<Ordering> orderings) {
> +    public SelectQuery(DbEntity root, Expression qualifier, List<? =
extends Ordering> orderings) {
>         this();
>         this.init(root, qualifier);
>         addOrderings(orderings);
> @@ -290,7 +290,7 @@ public class SelectQuery<T> extends Qual
>      *            defines how to order the results, may be null.
>      * @since 3.1
>      */
> -    public SelectQuery(String objEntityName, Expression qualifier, =
List<Ordering> orderings) {
> +    public SelectQuery(String objEntityName, Expression qualifier, =
List<? extends Ordering> orderings) {
>         init(objEntityName, qualifier);
>         addOrderings(orderings);
>     }
> @@ -497,7 +497,7 @@ public class SelectQuery<T> extends Qual
>     /**
>      * Adds a list of orderings.
>      */
> -    public void addOrderings(List<Ordering> orderings) {
> +    public void addOrderings(List<? extends Ordering> orderings) {
>         // If the supplied list of orderings is null, do not attempt =
to add
>         // to the collection (addAll() will NPE otherwise).
>         if (orderings !=3D null)
>=20
>=20
>=20