Return-Path: 
 <dev-return-8458-apmail-cayenne-dev-archive=cayenne.apache.org@cayenne.apache.org>
X-Original-To: apmail-cayenne-dev-archive@www.apache.org
Delivered-To: apmail-cayenne-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E3F469BC9
	for <apmail-cayenne-dev-archive@www.apache.org>;
 Fri, 27 Jan 2012 07:12:34 +0000 (UTC)
Received: (qmail 17158 invoked by uid 500); 27 Jan 2012 07:12:34 -0000
Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org
Received: (qmail 17026 invoked by uid 500); 27 Jan 2012 07:12:28 -0000
Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cayenne.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cayenne.apache.org>
List-Post: <mailto:dev@cayenne.apache.org>
List-Id: <dev.cayenne.apache.org>
Reply-To: dev@cayenne.apache.org
Delivered-To: mailing list dev@cayenne.apache.org
Received: (qmail 16983 invoked by uid 99); 27 Jan 2012 07:12:24 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2012 07:12:24 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [208.78.103.231] (HELO vorsha.objectstyle.org) (208.78.103.231)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Jan 2012 07:12:16 +0000
Received: (qmail 25080 invoked from network); 27 Jan 2012 07:11:54 -0000
Received: from unknown (HELO ?192.168.1.79?) (194.158.197.10)
  by vorsha.objectstyle.org with SMTP; 27 Jan 2012 07:11:54 -0000
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: SelectQuery + Orderings
From: Andrus Adamchik <andrus@objectstyle.org>
In-Reply-To: <4F21F7B6.1060608@maniatis.org>
Date: Fri, 27 Jan 2012 10:11:53 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <032F84BE-64D5-4A57-BAE1-AF5305ACFEA1@objectstyle.org>
References: 
 <CAA-upzop6mXXm1wEAB6x7-6YVmWbKk9J2FaQmBfR-mK5u+0mZA@mail.gmail.com>
 <4F21F7B6.1060608@maniatis.org>
To: dev@cayenne.apache.org
X-Mailer: Apple Mail (2.1084)

IMO all of the suggestions are good. Summarizing:

1. SelectQuery(Class<?>, Expression) becomes an equivalent =
SelectQuery(Class<?>, Expression, Ordering...)
2. (new) SelectQuery(Class<?>, Expression, List<Ordering>)
3. (new) SelectQuery order(String, SortOrder)
4. (new) SelectQuery order(Ordering... ordering)
5. (new) SelectQuery order(List<Ordering> orderings)

6. (deprecated) void addOrdering / addOrderings

On Jan 27, 2012, at 4:02 AM, Aristedes Maniatis wrote:

> On 27/01/12 4:15 AM, Michael Gentry wrote:
>> Any thoughts on updating SelectQuery.java to handle Orderings as:
>>=20
>> SelectQuery(Class, Expression, Ordering) or
>> SelectQuery(Class, Expression, List<Ordering>) or
>> SelectQuery(Class, Expression, Ordering...) or
>> public SelectQuery addOrdering(Ordering ordering) and
>> public SelectQuery addOrderings(List<Ordering>  orderings) ...
>>=20
>> I'm personally thinking the last, so it is chainable.
>=20
> Purely from a naming point of view, both of these:
>=20
>  public SelectQuery order(Ordering ordering)
>  public SelectQuery order(List<Ordering> orderings)
>=20
> This is then chainable, and will read very nicely, particularly when =
combined with similar functions for "limit", "join/prefetch", etc.
>=20
>=20
>=20
> Ari
>=20
>=20
> --=20
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A
>=20