Return-Path: X-Original-To: apmail-cayenne-dev-archive@www.apache.org Delivered-To: apmail-cayenne-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E204C7074 for ; Mon, 1 Aug 2011 13:00:09 +0000 (UTC) Received: (qmail 54635 invoked by uid 500); 1 Aug 2011 13:00:09 -0000 Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org Received: (qmail 54592 invoked by uid 500); 1 Aug 2011 13:00:09 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 54584 invoked by uid 99); 1 Aug 2011 13:00:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2011 13:00:08 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of razumovsky.andrey@gmail.com designates 209.85.216.171 as permitted sender) Received: from [209.85.216.171] (HELO mail-qy0-f171.google.com) (209.85.216.171) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2011 13:00:03 +0000 Received: by qyl38 with SMTP id 38so1156227qyl.16 for ; Mon, 01 Aug 2011 05:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=YIyXU4yBdcY8yHpfqbLaUFwYi5/3urTj53WInwCahfI=; b=T3Tgbbd1PuUGGwEnh4nrESuKP4ykbuvM+JGDeC4dmVfZpaM8r9F9R3aiFm30QcrzLE 3Cddr53NXG96l6mJh1Y8GW/dBRJfnblMkTb5sJB2TV6goXQYklrRVpjHkVL43aK1YVft ejr67mUSNN2l6k4ZO+kuCuuxyBx74fOVwAJdI= Received: by 10.229.45.11 with SMTP id c11mr1848451qcf.214.1312203582150; Mon, 01 Aug 2011 05:59:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.47.5 with HTTP; Mon, 1 Aug 2011 05:59:22 -0700 (PDT) In-Reply-To: References: <4E367A3A.5020704@maniatis.org> <77D86484-BD07-4F54-BBA0-CBD3386F839D@objectstyle.org> From: Andrey Razumovsky Date: Mon, 1 Aug 2011 16:59:22 +0400 Message-ID: Subject: Re: Sonar To: dev@cayenne.apache.org Content-Type: multipart/alternative; boundary=0016363ba24c6319b504a9713400 X-Virus-Checked: Checked by ClamAV on apache.org --0016363ba24c6319b504a9713400 Content-Type: text/plain; charset=ISO-8859-1 I've found this saying URLs are not good as keys for map/set (not performance issues though): http://alan.blog-city.com/do_not_use_javaneturl_as_a_key_in_hashmap.htm Author advices to use URL.toString() as key instead. As for the false positives, I agree completely, obviously most of those ~10k defects are false positives. This shouldn't be taken too seriously. 2011/8/1 Michael Gentry > I'll have to look more later, but these tools often generate lots of > false positives and need a way to silence warnings from run-to-run. > > mrg > > > On Mon, Aug 1, 2011 at 8:42 AM, Andrus Adamchik > wrote: > > Depends on whether their assertion about DNS lookups is true. We are > using local URLs anyways, and nobody complained to date, but certainly worth > a run in a debugger. > > > > On Aug 1, 2011, at 3:30 PM, Michael Gentry wrote: > > > >> Is this really a blocker? > >> > >> > https://analysis.apache.org/drilldown/violations/org.apache.cayenne:cayenne-parent?priority=BLOCKER# > >> > >> Thanks, > >> > >> mrg > >> > >> > >> On Mon, Aug 1, 2011 at 6:04 AM, Aristedes Maniatis > wrote: > >>> https://analysis.apache.org/dashboard/index/67484 > >>> > >>> We can certainly throw out all the findbugs/clover/etc cruft now. This > is > >>> much better. > >>> > >>> Ari > >>> > >>> > >>> -- > >>> --------------------------> > >>> Aristedes Maniatis > >>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > >>> > >> > > > > > -- Andrey --0016363ba24c6319b504a9713400--