cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eshan Sudharaka <esudhar...@gmail.com>
Subject Re: Gsoc project Patch
Date Tue, 21 Jun 2011 16:07:18 GMT
On Mon, Jun 20, 2011 at 11:05 PM, Ksenia Khailenko
<xenia_khailenka@tut.by>wrote:

> Hi there!
>
> Eshan, I've applied your patch, and here're some comments:
>
> 1) cayenne-modeler-eclipse-plugin-II - let's choose some more meaningful
> name for the project… Say, while it is experimental it can be
> cayenne-modeler-eclipse-plugin-gsoc, and then when we will finish - just
> cayenne-modeler-eclipse-plugin.. I don't like this "II" very much..
>
> 2) the root folder ("cayenne-modeler-eclipse-plugin-II" for now) should
> also
> be included into the patch
>
> 3)pom.xml:
> <bundle.symbolicName>cayenne-modeler-eclipse-plugin</bundle.symbolicName>
> the symbolic name,artifactId,  and the name of the project should be equal
> to the enclosing folder - that's why it is so important to choose the good
> name for it; and also, please format your code
>
> 4) plugin.patch is useless here - I've included this file into my project
> in
> order not to forget some details from the old Cay-1392, but you don't need
> it
>
> 5) as for dependencies - are sure we can't use some public repository? say,
> this one:
> http://www.mvnbrowser.com/artifacts-browse.html?groupId=org.eclipse ? as I
> can see, there all the needed dependencies here
>
> 6) Add some picture for your editor - hard to find it in list
>
> I added cayenne.png as the icon for editor. But it seems image size is too
large so it is not appear on the editor (I tested icon configuration with
eclipse giff image and it is working).

> 7) try to launch your plugin not as eclipse application, but as standalone
> artifact - the simplest way, when you are copying your jar into plugins
> eclipse folder and launching eclipse. this may be not so easy…
>
> I've just tested the building and launching of the project, haven't looked
> in depth, but in general, it looks nice, good work!:) I'm looking forward
> for your further updates.
>
> 2011/6/17 Eshan Sudharaka <esudharaka@gmail.com>
>
> > Hi Ksenia,
> >         I have attached a patch of my current work and  the zipped
> > repository folder. Apply this patch and copy this folder in to
> > /sandbox/cayenne-modeler-eclipse-plugin-II .
> >
> > I will create a list of used third party dependencies and attached it on
> > jira issue with the patch file.
> >
> > --
> > *~Thanks & Regards~*
> > ***
> > *
> > P.A.Eshan Sudharaka
> > Dept of Computer Science and Engineering
> > University of Moratuwa
> > Sri Lanka
> > http://esudharaka.blogspot.com/
> >
> >
>
>
> --
> Regards, Ksenia Khailenko
>



-- 
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message