Return-Path: Delivered-To: apmail-cayenne-dev-archive@www.apache.org Received: (qmail 61983 invoked from network); 18 Apr 2010 11:32:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 Apr 2010 11:32:19 -0000 Received: (qmail 75708 invoked by uid 500); 18 Apr 2010 11:32:19 -0000 Delivered-To: apmail-cayenne-dev-archive@cayenne.apache.org Received: (qmail 75679 invoked by uid 500); 18 Apr 2010 11:32:18 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 75671 invoked by uid 99); 18 Apr 2010 11:32:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Apr 2010 11:32:18 +0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=AWL,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of apparition077@gmail.com designates 209.85.218.226 as permitted sender) Received: from [209.85.218.226] (HELO mail-bw0-f226.google.com) (209.85.218.226) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Apr 2010 11:32:12 +0000 Received: by bwz26 with SMTP id 26so3717476bwz.27 for ; Sun, 18 Apr 2010 04:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:received:message-id:subject :from:to:content-type:content-transfer-encoding; bh=4KYYS3G54tLsWImp+qnLed2UPM+kxtn2Nch0/AIpr3s=; b=LxVeh7FX4XvxH3SNTkaZCZcAtrfGrDpZNkKB2pvOxoE44KnNmX3OnIFEOeC7NCkNXa CbVhSqIc0+e63/XagDLR7w83x9k1pZJpoBTWhyh4rPRi4kyo7vJ6h8XzCPy97CVm29/F +X4v6uCV8W9agJnIwTDAm77wz+zFUEyNvkw4w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=YhSjMIsSswJxP067kyxgv8GDYbarVIUUklcO9WaNjTt15EFLHW4HLw1QtAqT7CFtxd VseXtbhQ1IHEri1ZWTXZrx22VhE8EVCrKemfk/H4uJdkyp5zKramqwUekYkSppm9oXak owPRR9iQPQBJzigc/iMMhdEtSXPLQmhr1Nql4= MIME-Version: 1.0 Sender: apparition077@gmail.com Received: by 10.204.118.201 with HTTP; Sun, 18 Apr 2010 04:31:51 -0700 (PDT) In-Reply-To: <9AA907D1-4068-41EB-8A68-1F956C3419E3@objectstyle.org> References: <20100417164655.D974323888EC@eris.apache.org> <9AA907D1-4068-41EB-8A68-1F956C3419E3@objectstyle.org> Date: Sun, 18 Apr 2010 15:31:51 +0400 X-Google-Sender-Auth: f627e6be9fd7bfb8 Received: by 10.204.33.16 with SMTP id f16mr3444419bkd.11.1271590311147; Sun, 18 Apr 2010 04:31:51 -0700 (PDT) Message-ID: Subject: Re: svn commit: r935207 - in /cayenne/main/trunk: docs/doc/src/main/resources/ framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/ framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/query/ From: Evgeny Ryabitskiy To: dev@cayenne.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable This was add to fix another JUnit test (that was failing). JUnit test was expecting that this flag is false while use setFatchingDataR= ows. So I add it here, to didn't change previous behavior Maybe I didn't understand the meaning of SQLResult.... Evgeny. 2010/4/18 Andrus Adamchik : > > On Apr 18, 2010, at 12:46 AM, evgeny@apache.org wrote: > >> =A0 =A0public void setResult(SQLResult resultSet) { >> + =A0 =A0 =A0 =A0setFetchingDataRows(false); // turn off mapping to Data= Rows, use >> explicit >> =A0 =A0 =A0 =A0this.result =3D resultSet; >> =A0 =A0} > > Implicit flipping of the DataRows flag outside constructor seems > counterintuitive. Also SQLResult is not equal to an object fetch. So I th= ink > this is wrong. > > Andrus