cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evgeny Ryabitskiy <evgeny.ryabits...@gmail.com>
Subject Re: svn commit: r935207 - in /cayenne/main/trunk: docs/doc/src/main/resources/ framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/ framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/query/
Date Sun, 18 Apr 2010 11:31:51 GMT
This was add to fix another JUnit test (that was failing).
JUnit test was expecting that this flag is false while use setFatchingDataRows.
So I add it here, to didn't change previous behavior
Maybe I didn't understand the meaning of SQLResult....

Evgeny.


2010/4/18 Andrus Adamchik <andrus@objectstyle.org>:
>
> On Apr 18, 2010, at 12:46 AM, evgeny@apache.org wrote:
>
>>    public void setResult(SQLResult resultSet) {
>> +        setFetchingDataRows(false); // turn off mapping to DataRows, use
>> explicit
>>        this.result = resultSet;
>>    }
>
> Implicit flipping of the DataRows flag outside constructor seems
> counterintuitive. Also SQLResult is not equal to an object fetch. So I think
> this is wrong.
>
> Andrus

Mime
View raw message