cayenne-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Рябицкий Евгений <eryabits...@diasoft.ru>
Subject RE: [jira] Commented: (CAY-1354) Wrong Types mapping for selected values in Row Queries
Date Mon, 11 Jan 2010 14:03:02 GMT
Still little bit confusing...


>I apply the latest patch from this Jira locally and run a test.
>>
>> *Result without the patch*
>>
>> *mysql* - all ok
>>

>it hsqldb - ok


So you applied patch or only add tests?
Tests shouldn't work on hsqldb without patch. At least I check everything on hsqldb and get
everything working there before publishing patch.


I guess... sections for *Result without the patch* and *Result with the patch* should be switched?
:) or it looks like my patch broke everything?

Also this tests assertation should be fixed (I will publish newer patch including that fixes)
  testSQLTemplateTimestamp(org.apache.cayenne.access.DateTimeTypesTest)
  testSQLTemplateDate(org.apache.cayenne.access.DateTimeTypesTest)
  testSQLTemplateTime(org.apache.cayenne.access.DateTimeTypesTest)


So there still:

*postgres*

Tests in error:
  testNullParameter(org.apache.cayenne.query.EJBQLQueryTest)
  testBindingForCollection(org.apache.cayenne.access.jdbc.BindDirectiveTest)

Second one is mine and quite new. It can be not well written.
Can't imagine how EJBQLQueryTest is related to my changes. Should see some logs...

*sqlserver*

Failed tests:
testFetchLimitWithOffset(org.apache.cayenne.query.SelectQueryTest)

Also strange fail. Can be related to some strange type assert.


Evgeny.



-----Original Message-----
From: Ольга Ткачева [mailto:tkachovaolga@gmail.com] 
Sent: Monday, January 11, 2010 4:47 PM
To: dev@cayenne.apache.org
Subject: Re: [jira] Commented: (CAY-1354) Wrong Types mapping for selected values in Row Queries

sorry, i have confused results mysql and hsqldb


I apply the latest patch from this Jira locally and run a test.
>
> *Result without the patch*
>
> *mysql* - all ok
>

it hsqldb - ok

mysql have old errors

Tests in error:
  test1MBClob(org.apache.cayenne.access.DataContextClobTest)
  test1MBBlob(org.apache.cayenne.access.DataContextBlobTest)

Tests run: 2083, Failures: 0, Errors: 2, Skipped: 0


>
> *Result with the patch*
>
> *mysql*
>
> Failed tests:
>   testSQLTemplateTimestamp(org.apache.cayenne.access.DateTimeTypesTest)
>   testSQLTemplateDate(org.apache.cayenne.access.DateTimeTypesTest)
>   testSQLTemplateTime(org.apache.cayenne.access.DateTimeTypesTest)
>
> Tests run: 2030, Failures: 3, Errors: 0, Skipped: 0
>
>

it hsqldb have this errors





>
>
>
>
> 2010/1/10 Andrus Adamchik (JIRA) <jira@apache.org>
>
>
>>    [
>> https://issues.apache.org/jira/browse/CAY-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798458#action_12798458]
>>
>> Andrus Adamchik commented on CAY-1354:
>> --------------------------------------
>>
>> Next week myself or Olga may try to test this patch in our environment
>> that includes PostgreSQL and SQLServer (I think the later was causing
>> trouble)...
>>
>> > Wrong Types mapping for selected values in Row Queries
>> > ------------------------------------------------------
>> >
>> >                 Key: CAY-1354
>> >                 URL: https://issues.apache.org/jira/browse/CAY-1354
>> >             Project: Cayenne
>> >          Issue Type: Bug
>> >          Components: Core Library
>> >    Affects Versions: 3.1M1
>> >            Reporter: Evgeny Ryabitskiy
>> >            Assignee: Evgeny Ryabitskiy
>> >            Priority: Critical
>> >             Fix For: 3.1M1
>> >
>> >         Attachments: CAY-1354.patch, CAY-1354_TEST.patch,
>> ReturnTypesMappingTest.java
>> >
>> >
>> >  By default every SQL type is mapped to some Java type by modeler.
>> > I am expecting same behavior in common DataRow queries (without ORM).
>> > But in fact half of types are not mapped correctly....
>> > Attached JUnit test can to explain problem with more details...
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
> --
> Olga Tkacheva
>



-- 
Olga Tkacheva

Mime
View raw message