Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cayenne.apache.org
Received-SPF: pass (athena.apache.org: domain of blacknext@gmail.com
 designates 64.233.182.187 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=cZ10lG2F68V6Ht7RtxmQD89RnNwb+XeqRkGjzaBy2PIMzJG6E1g3wg9vTCi0s6bMJk
         OO3MNjolK9qKQaLT6eS0TbeJUOZBccWJvy0Sp0D8gpZ2eO43YaqFkmP8cqB7lmUjzzGn
         ikfzY1bfesk5AcZ6i+fyJ5B9ntmSQHK/LOiA8=
Message-ID: <f65b8ae30809160739y7f63f047j2555b4fb079f5926@mail.gmail.com>
Date: Tue, 16 Sep 2008 10:39:57 -0400
From: "Michael Gentry" <blacknext@gmail.com>
To: dev@cayenne.apache.org
Subject: Re: svn commit: r695898 -
 /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
In-Reply-To: <6B1BB9FD-783B-4FAE-82EC-09911FC1699B@objectstyle.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080916142412.91DCF2388A08@eris.apache.org>
	 <B82BB20B-4470-42F6-8713-7AB94C968899@objectstyle.org>
	 <6B1BB9FD-783B-4FAE-82EC-09911FC1699B@objectstyle.org>

So there is no good way of caching parsed expressions, then?

Thanks!


On Tue, Sep 16, 2008 at 10:36 AM, Andrus Adamchik
<andrus@objectstyle.org> wrote:
> Also (c) (related to my "emeddable" note) - in an environment like J2EE,
> where there are layers upon layers of explicit and implicit containers
> between the VM and the application code, having a static object storage
> buried in a framework is a bad practice - it prevents the container layers
> from performing their functions of isolating "contexts" for various users
> (whatever those contexts might be).
>
> Andrus
>
> On Sep 16, 2008, at 5:30 PM, Andrus Adamchik wrote:
>
>> -1. Unmanaged static caches are bad, especially in an embeddable framework
>> like Cayenne. This is (a) a potential memory leak and (b) a potential
>> synchronization nightmare (Expression is not immutable and can be modified
>> by the caller).
>>
>> Andrus
>>
>>
>> On Sep 16, 2008, at 5:24 PM, mgentry@apache.org wrote:
>>
>>> Author: mgentry
>>> Date: Tue Sep 16 07:24:11 2008
>>> New Revision: 695898
>>>
>>> URL: http://svn.apache.org/viewvc?rev=695898&view=rev
>>> Log:
>>> Updated Expression.fromString to cache the parsed expressions instead of
>>> re-parsing them every time.
>>>
>>> Modified:
>>>
>>>  cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
>>>
>>> Modified:
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
>>> URL:
>>> http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java?rev=695898&r1=695897&r2=695898&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
>>> (original)
>>> +++
>>> cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
>>> Tue Sep 16 07:24:11 2008
>>> @@ -26,6 +26,7 @@
>>> import java.io.StringWriter;
>>> import java.util.Collection;
>>> import java.util.Collections;
>>> +import java.util.HashMap;
>>> import java.util.LinkedList;
>>> import java.util.List;
>>> import java.util.Map;
>>> @@ -119,21 +120,36 @@
>>>
>>>   protected int type;
>>>
>>> +    private static Map<String, Expression> expressionCache =
>>> +        Collections.synchronizedMap(new HashMap<String,
>>> Expression>(32));
>>> +
>>>   /**
>>>    * Parses string, converting it to Expression. If string does not
>>> represent a
>>>    * semantically correct expression, an ExpressionException is thrown.
>>>    *
>>>    * @since 1.1
>>>    */
>>> -    // TODO: cache expression strings, since this operation is pretty
>>> slow
>>>   public static Expression fromString(String expressionString) {
>>>       if (expressionString == null) {
>>>           throw new NullPointerException("Null expression string.");
>>>       }
>>>
>>> -        Reader reader = new StringReader(expressionString);
>>> +        // Retrieve, if possible, the expression from the cache.
>>> +        Expression expression = expressionCache.get(expressionString);
>>> +
>>> +        // If the expression was cached, return it immediately without
>>> parsing.
>>> +        if (expression != null)
>>> +            return expression;
>>> +
>>> +        // Couldn't find expression, parse, cache, and return it.
>>>       try {
>>> -            return new ExpressionParser(reader).expression();
>>> +            Reader reader = new StringReader(expressionString);
>>> +
>>> +            expression = new ExpressionParser(reader).expression();
>>> +
>>> +            expressionCache.put(expressionString, expression);
>>> +
>>> +            return expression;
>>>       }
>>>       catch (ParseException ex) {
>>>           throw new ExpressionException(ex.getMessage(), ex);
>>>
>>
>>
>
>