From commits-return-25728-archive-asf-public=cust-asf.ponee.io@cayenne.apache.org Tue Jul 9 15:11:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8284618062B for ; Tue, 9 Jul 2019 17:11:01 +0200 (CEST) Received: (qmail 84544 invoked by uid 500); 9 Jul 2019 15:11:01 -0000 Mailing-List: contact commits-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list commits@cayenne.apache.org Received: (qmail 84535 invoked by uid 99); 9 Jul 2019 15:11:00 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2019 15:11:00 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 55A83E0782 for ; Tue, 9 Jul 2019 15:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 141F52656F for ; Tue, 9 Jul 2019 15:11:00 +0000 (UTC) Date: Tue, 9 Jul 2019 15:11:00 +0000 (UTC) From: "Andrus Adamchik (JIRA)" To: commits@cayenne.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CAY-2019) Optimistic locking always fails on CRYPTO columns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAY-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881297#comment-16881297 ] Andrus Adamchik edited comment on CAY-2019 at 7/9/19 3:10 PM: -------------------------------------------------------------- > So is there a better place to turn off locking then? We can decorate DataMapLoader and inspect loaded DataMap for attributes that are both using optimistic locking and are encrypted (using the actual implementation of ColumnMapper) . I'd still prefer printing a warning in the logs to just turning it off (or we can do both actually), but either way it will happen in the same place. was (Author: andrus): > So is there a better place to turn off locking then? We can decorate DataMapLoader and inspect loaded DataMap for attributes that are both using optimistic locking and are encrypted (using the actual implementation of ColumnMapper) . I'd still prefer printing a warning in the logs to just turning it off, but either way it will happen in the same place. > Optimistic locking always fails on CRYPTO columns > ------------------------------------------------- > > Key: CAY-2019 > URL: https://issues.apache.org/jira/browse/CAY-2019 > Project: Cayenne > Issue Type: Bug > Components: Core Library > Affects Versions: 4.0.M2 > Reporter: John Huss > Assignee: John Huss > Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > If you have optimistic locking turned on for columns that are configured to be encrypted (named CRYPTO_*) then updates to those rows will always fail because it uses the unencrypted value to check the optimistic locking, ie. WHERE encryptedColumn = -- This message was sent by Atlassian JIRA (v7.6.3#76005)