From commits-return-25231-archive-asf-public=cust-asf.ponee.io@cayenne.apache.org Thu Mar 21 06:54:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 309FE18077A for ; Thu, 21 Mar 2019 07:54:36 +0100 (CET) Received: (qmail 28599 invoked by uid 500); 21 Mar 2019 06:54:35 -0000 Mailing-List: contact commits-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list commits@cayenne.apache.org Received: (qmail 28576 invoked by uid 99); 21 Mar 2019 06:54:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2019 06:54:35 +0000 From: GitBox To: commits@cayenne.apache.org Subject: [GitHub] [cayenne] hugith commented on a change in pull request #371: New BeanAccessor constructor, allowing custom accessor method names Message-ID: <155315127451.15179.16317384958598217624.gitbox@gitbox.apache.org> Date: Thu, 21 Mar 2019 06:54:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hugith commented on a change in pull request #371: New BeanAccessor constructor, allowing custom accessor method names URL: https://github.com/apache/cayenne/pull/371#discussion_r267637885 ########## File path: cayenne-server/src/main/java/org/apache/cayenne/reflect/BeanAccessor.java ########## @@ -152,4 +163,19 @@ public void setValue(Object object, Object newValue) throws PropertyException { throw new PropertyException("Error writing property: " + propertyName, this, object, th); } } + Review comment: No, this is basically the same implementation as before (just moved from the constructor to a method) so it should be functionally equivalent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services