cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-2379) Modeler: Visualization issue after an undo action for a deleted ObjAttribute
Date Fri, 10 Nov 2017 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/CAY-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247633#comment-16247633
] 

ASF GitHub Bot commented on CAY-2379:
-------------------------------------

GitHub user emecas opened a pull request:

    https://github.com/apache/cayenne/pull/246

    Fixed CAY-2379 by focusing the ObjEntity after the undo RemoveAttributeUndoableEdit  Action

    Fixed CAY-2379 by focusing the ObjEntity after the undo RemoveAttributeUndoableEdit action
    
    - Added getter on `RemoveAttributeUndoableEdit` to be able to access the `ObjEntity` 
    - Divided and set public access to `viewCounterpartEntity` method of `DbEntityCounterpartAction`
to be able to switch to the ObjEntity from `CayenneUndoManager` 
    - added `focusObjEntity` method  to `CayenneUndoManager` class
    - Added logic in `CayenneUndoManager` to handling the focus for a `RemoveAttributeUndoableEdit`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/emecas/cayenne CAY-2379

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 969017dabb7f0fd41f37c7e32c939df217a18fca
Author: Emerson Castaneda <emecas@users.noreply.github.com>
Date:   2017-11-10T14:58:31Z

    Fixed CAY-2379 by focusing the ObjEntity after the undo RemoveAttributeUndoableEdit action

----


> Modeler: Visualization issue after an undo action for a deleted ObjAttribute 
> -----------------------------------------------------------------------------
>
>                 Key: CAY-2379
>                 URL: https://issues.apache.org/jira/browse/CAY-2379
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Modeler
>    Affects Versions: 4.1.M1
>            Reporter: Emerson Castaneda
>            Assignee: Nikita Timofeev
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.1.M2
>
>         Attachments: CAY-2379.pdf
>
>
> The modeler misbehaves during an undo action, it's only regarding to visualization subject.
> How to reproduce:
> Precondition: In a project with at least 2 Object Entities: ObjEntity1 and ObjEntity2
> # go to ObjEntity1 and remove an ObjAttribute 
> # switch to ObjEntity2, properties Tab
> # go to main menu and select undo
> # the ObjAttributed removed from ObjEntity1 is now in the attributes list of ObjEntity2
> I have figured out while working in complex project during the undo action, when suddenly
a Object Entity lost multiple attributes (about 5) after the undo action, so I close the project,
just in case, without save and then open it again to avoid make the change permanent. 
> Trying to reproduce the issue, looks like this is only related to visualization and get
solved by switching to a different object, even saving the change the original attribute is
back to the right entity, but the visualization is not consistent right after the undo action.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message