cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lonvarscsak <...@git.apache.org>
Subject [GitHub] cayenne pull request #176: Reverse Engineering doesn't work with Sybase
Date Mon, 13 Mar 2017 22:04:29 GMT
GitHub user lonvarscsak opened a pull request:

    https://github.com/apache/cayenne/pull/176

    Reverse Engineering doesn't work with Sybase

    Modified connection.getSchema() call to be wrapped in try/catch block with a warning to
the log.  In Sybase, getSchema() throws an Error because technically a schema isn't a valid
concept.  The closest comparison in Sybase is the owner of the object (usually "dbo").  In
this case, "currentSchema" will be null (which doesn't appear to have any consequences).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthealth/cayenne sybase-reverse-engineer-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 611e96ead591060b882f66b58174c82aebb7b62b
Author: Lon Varscsak <lon.varscsak@gmail.com>
Date:   2017-03-13T21:46:49Z

    Modified connection.getSchema() call to be wrapped in try/catch block
    with a warning to the log.  In Sybase, getSchema() throws an Error (not
    an Exception) because technically a schmea isn't a valid concept.  The
    closes comparison in Sybase is the owner of the object (usually "dbo").
    In this case, "currentSchema" will be null (which doesn't appear to have
    any consequences).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message