Mailing-List: contact commits-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cayenne.apache.org
Date: Thu, 9 Feb 2017 01:33:41 +0000 (UTC)
From: "Andrus Adamchik (JIRA)" <jira@apache.org>
To: commits@cayenne.apache.org
Message-ID: <JIRA.13041558.1486603929000.34399.1486604021713@Atlassian.JIRA>
In-Reply-To: <JIRA.13041558.1486603929000@Atlassian.JIRA>
References: <JIRA.13041558.1486603929000@Atlassian.JIRA> <JIRA.13041558.1486603929296@jira-lw-us.apache.org>
Subject: [jira] [Updated] (CAY-2222) MySQLAdapter should not create indexes
 on FK columns
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Feb 2017 01:33:50 -0000


     [ https://issues.apache.org/jira/browse/CAY-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik updated CAY-2222:
---------------------------------
    Description: 
MySQLAdapter has this comment in the "createTableAppendPKClause" method:

// if FK constraints are supported, we must add indices to all FKs
// Note that according to MySQL docs, FK indexes are created
// automatically when constraint is defined, starting at MySQL 4.1.2

And then it proceeds to add indexes for all FKs. This becomes a problem when a user wants to generate MySQL schema without FK constraints. In which case those columns still end up having an index. While we can refactor this in a backwards compatible manner, I think we can just drop support for explicit index creation, streamlining the code. After all MySQL 4.1.2 was released in 2004. 

If someone still needs support for older MySQL, I guess a whole new adapter should be created.


  was:
MySQLAdapter has this comment in the "createTableAppendPKClause" method:

// if FK constraints are supported, we must add indices to all FKs
// Note that according to MySQL docs, FK indexes are created
// automatically when constraint is defined, starting at MySQL 4.1.2

and then it proceeds to add indexe for all FKs.

This becomes a problem when a user wants to generate MySQL schema without FK constraints. In which case those columns still end up having an index.

While we can refactor this in a backwards compatible manner, I think we can just drop support for explicit index creation. After all MySQL 4.1.2 was released in 2004. 


> MySQLAdapter should not create indexes on FK columns
> ----------------------------------------------------
>
>                 Key: CAY-2222
>                 URL: https://issues.apache.org/jira/browse/CAY-2222
>             Project: Cayenne
>          Issue Type: Bug
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>            Priority: Minor
>             Fix For: 4.0.M5
>
>
> MySQLAdapter has this comment in the "createTableAppendPKClause" method:
> // if FK constraints are supported, we must add indices to all FKs
> // Note that according to MySQL docs, FK indexes are created
> // automatically when constraint is defined, starting at MySQL 4.1.2
> And then it proceeds to add indexes for all FKs. This becomes a problem when a user wants to generate MySQL schema without FK constraints. In which case those columns still end up having an index. While we can refactor this in a backwards compatible manner, I think we can just drop support for explicit index creation, streamlining the code. After all MySQL 4.1.2 was released in 2004. 
> If someone still needs support for older MySQL, I guess a whole new adapter should be created.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)