Return-Path: X-Original-To: apmail-cayenne-commits-archive@www.apache.org Delivered-To: apmail-cayenne-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66C8C17233 for ; Sun, 2 Nov 2014 10:42:34 +0000 (UTC) Received: (qmail 7621 invoked by uid 500); 2 Nov 2014 10:42:33 -0000 Delivered-To: apmail-cayenne-commits-archive@cayenne.apache.org Received: (qmail 7591 invoked by uid 500); 2 Nov 2014 10:42:33 -0000 Mailing-List: contact commits-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list commits@cayenne.apache.org Received: (qmail 7581 invoked by uid 99); 2 Nov 2014 10:42:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Nov 2014 10:42:33 +0000 Date: Sun, 2 Nov 2014 10:42:33 +0000 (UTC) From: "Andrus Adamchik (JIRA)" To: commits@cayenne.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CAY-1967) Deprecate SQLTemplate parameter batches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAY-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrus Adamchik updated CAY-1967: --------------------------------- Description: One of the hurdles in creating a cleaner API for SQLTemplate is its support for parameter batches: SQLTemplate template = ... Map[] params = new Map<>[2]; params[0] = .. params[1] = .. sqlTemplate.setParams(params); There's a very small performance benefit to using batches, as PreparedStatement is not precompiled between the batch bindings. So switching this form instance to QueryChain is not going to have much effect on speed, but makes things cleaner: SQLTemplate template = ...; Query[] queries = new Query[2]; queries[0] = template.queryQueryWithParameters(..); queries[1] = template.queryQueryWithParameters(..); QueryChain chain = new QueryChain(queries); So going to deprecate parameter batches. was: One of the hurdles in creating a cleaner API for SQLTemplate is its support for parameter batches: SQLTemplate template = ... Map[] params = new Map<>[2]; params[0] = .. params[1] = .. sqlTemplate.setParams(params); There's a very small performance benefit to using batches vs. say using QueryChain: SQLTemplate template = ...; Query[] queries = new Query[2]; queries[0] = template.queryQueryWithParameters(..); queries[1] = template.queryQueryWithParameters(..); QueryChain chain = new QueryChain(queries); Probably not noticeable enough by anyone. So going to deprecate parameter batches. > Deprecate SQLTemplate parameter batches > --------------------------------------- > > Key: CAY-1967 > URL: https://issues.apache.org/jira/browse/CAY-1967 > Project: Cayenne > Issue Type: Improvement > Reporter: Andrus Adamchik > Assignee: Andrus Adamchik > > One of the hurdles in creating a cleaner API for SQLTemplate is its support for parameter batches: > SQLTemplate template = ... > Map[] params = new Map<>[2]; > params[0] = .. > params[1] = .. > sqlTemplate.setParams(params); > There's a very small performance benefit to using batches, as PreparedStatement is not precompiled between the batch bindings. So switching this form instance to QueryChain is not going to have much effect on speed, but makes things cleaner: > SQLTemplate template = ...; > Query[] queries = new Query[2]; > queries[0] = template.queryQueryWithParameters(..); > queries[1] = template.queryQueryWithParameters(..); > QueryChain chain = new QueryChain(queries); > So going to deprecate parameter batches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)