cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-1964) Fix convertAdditionalDataMaps() in CayenneGeneratorMojo.java
Date Thu, 30 Oct 2014 13:03:34 GMT

    [ https://issues.apache.org/jira/browse/CAY-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190022#comment-14190022
] 

ASF GitHub Bot commented on CAY-1964:
-------------------------------------

GitHub user thinline72 opened a pull request:

    https://github.com/apache/cayenne/pull/24

    CAY-1964 | Fix convertAdditionalDataMaps() in CayenneGeneratorMojo.java

    Fix convertAdditionalDataMaps() in CayenneGeneratorMojo.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thinline72/cayenne CAY-1964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 5b6b60c9b7ae8193457e93739a307416cd338db8
Author: Savva Kolbechev <s.kolbachev@gmail.com>
Date:   2014-10-30T13:01:29Z

    CAY-1964 | Fix convertAdditionalDataMaps() in CayenneGeneratorMojo.java

----


> Fix convertAdditionalDataMaps() in CayenneGeneratorMojo.java
> ------------------------------------------------------------
>
>                 Key: CAY-1964
>                 URL: https://issues.apache.org/jira/browse/CAY-1964
>             Project: Cayenne
>          Issue Type: Bug
>            Reporter: Savva Kolbachev
>
> 1. 'convertAdditionalDataMaps' method does not do extension filtering, so there
> is a good chance it will include unrelated files, then try to parse them as
> DataMaps downstream, then fail. 
> 2. 'convertAdditionalDataMaps' doesn't set the absolute path when creating a
> File, so it is resolved against an incorrect base directory. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message