Return-Path: X-Original-To: apmail-cayenne-commits-archive@www.apache.org Delivered-To: apmail-cayenne-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FABE10FA6 for ; Wed, 4 Dec 2013 20:06:35 +0000 (UTC) Received: (qmail 50649 invoked by uid 500); 4 Dec 2013 20:06:35 -0000 Delivered-To: apmail-cayenne-commits-archive@cayenne.apache.org Received: (qmail 50635 invoked by uid 500); 4 Dec 2013 20:06:35 -0000 Mailing-List: contact commits-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list commits@cayenne.apache.org Received: (qmail 50627 invoked by uid 99); 4 Dec 2013 20:06:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 20:06:35 +0000 Date: Wed, 4 Dec 2013 20:06:35 +0000 (UTC) From: "Andrus Adamchik (JIRA)" To: commits@cayenne.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (CAY-1890) Remove Cayenne-level buffering when retrieving LOBs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAY-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrus Adamchik closed CAY-1890. -------------------------------- Resolution: Fixed > Remove Cayenne-level buffering when retrieving LOBs > --------------------------------------------------- > > Key: CAY-1890 > URL: https://issues.apache.org/jira/browse/CAY-1890 > Project: Cayenne > Issue Type: Improvement > Reporter: Andrus Adamchik > Assignee: Andrus Adamchik > Priority: Minor > Fix For: 3.2.M2 > > > Something like a patch below marginally improves CLOB read speed on Oracle, letting the driver handle buffering. I don't have data for other DBs , but I would imagine it should work at least as well. > +++ b/cayenne-server/src/main/java/org/apache/cayenne/access/types/CharType.java > @@ -19,7 +19,6 @@ > > package org.apache.cayenne.access.types; > > -import java.io.BufferedReader; > import java.io.IOException; > import java.io.Reader; > import java.io.StringWriter; > @@ -153,13 +152,7 @@ public class CharType implements ExtendedType { > return ""; > } > > - int bufSize = (size < BUF_SIZE) ? size : BUF_SIZE; > - > - Reader in = clob.getCharacterStream(); > - return (in != null) ? readValueStream( > - new BufferedReader(in, bufSize), > - size, > - bufSize) : null; > + return clob.getSubString(1, size); > } > > protected String readCharStream(ResultSet rs, int index) throws IOException, -- This message was sent by Atlassian JIRA (v6.1#6144)