cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (CAY-1700) Split long DISJOINT_BY_ID prefetch query on several smaller queries
Date Sat, 05 May 2012 10:49:50 GMT

     [ https://issues.apache.org/jira/browse/CAY-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrus Adamchik closed CAY-1700.
--------------------------------

    Resolution: Fixed

Patch applied. I did some refactoring for DataDomain to avoid reading the property value every
time from RuntimeProperties (it appears that injection of RuntimeProperties into deeper runtime
objects is an antipattern creating close copupling between configuration and runtime). 

Instead introduced an ivar in DataDomain. Among other things this solved the issue of unit
tests setting a static System property. Now we can simply do it per test:

 runtime.getDataDomain().setMaxIdQualifierSite(100);
                
> Split long DISJOINT_BY_ID prefetch query on several smaller queries
> -------------------------------------------------------------------
>
>                 Key: CAY-1700
>                 URL: https://issues.apache.org/jira/browse/CAY-1700
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Core Library
>    Affects Versions: 3.1M4
>            Reporter: Andrei Veprev
>             Fix For: 3.1M4
>
>         Attachments: CAY-1700.patch
>
>
> It is improvement for CAY-1681. From Andrus' comment:
> And one more thing we will probably have to implement - breaking down OR query if it
gets too long. This is a real problem which has been repeatedly mentioned in the context of
the paginated queries, and in fact solved in IncrementalFaultList. see IncrementalFaultList.resolveInterval
- it checks the number of clauses in the qualifier against 'maxFetchSize'. We may need to
make "maxFetchSize" a container property used by IncrementalFaultList as well as our prefetch
strategy, and take it into account in the later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message