cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wernke zur Borg (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAY-1655) Logger injection to JdbcAdapter subclass does not work
Date Thu, 09 Feb 2012 08:24:59 GMT

    [ https://issues.apache.org/jira/browse/CAY-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204351#comment-13204351
] 

Wernke zur Borg commented on CAY-1655:
--------------------------------------

Hi Andrus, thanks for testing this.

My factory is as simple as:

public class MyCustomDbAdapterFactory implements DbAdapterFactory {
	public DbAdapter createAdapter(DataNodeDescriptor nodeDescriptor,
			DataSource dataSource) throws Exception {
		return new MyCustomAdapter();
	}
}

My adapter looks like this:

public class MyCustomAdapter extends JdbcAdapter {
	public MyCustomAdapter() {
		this.logger = new CommonsJdbcEventLogger(); // only because logger injection does not work
for me
	}
	
    @Override
    public SQLAction getAction(Query query, DataNode node) {
        return query.createSQLAction(new MyCustomActionBuilder(this, node.getEntityResolver()));
    }
}

MyActionBuilder just overrides objectSelectAction() because I need a specific syntax for the
SELECT query.



                
> Logger injection to JdbcAdapter subclass does not work
> ------------------------------------------------------
>
>                 Key: CAY-1655
>                 URL: https://issues.apache.org/jira/browse/CAY-1655
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Core Library
>    Affects Versions: 3.1M3
>         Environment: Windows 7, MS Access, JdbcOdbc driver
>            Reporter: Wernke zur Borg
>
> I created a custom subclass of JdbcAdapter for some special handling with MS Access.
It is instantiated by a custom DbAdapterFactory subclass, which is configured as:
> 		Module m = new Module() {
> 			public void configure(Binder binder) {
> 				binder.bind(DbAdapterFactory.class).to(MyCustomDbAdapterFactory.class);
> 			}
> 		};
> Now the application runs into a NullPointerException in org.apache.cayenne.access.jdbc.SelectAction.performAction()
where it says:
> adapter.getJdbcEventLogger()...  (line 171)
> This means that the injection of the JdbcEventLogger "logger" in my superclass JdbcAdapter
has not taken place. It might be important that also SelectAction has been subclassed with
a custom SelectAction.
> The problem does not occur when I comment the binder.bind(...) line out.
> Workaround: Instantiate a CommonsJdbcEventLogger in the custom JdbcAdapter and assign
it to the logger (it is protected). But this logger is not aware of the log4j log level. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message