cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aadamc...@apache.org
Subject svn commit: r954855 - /cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java
Date Tue, 15 Jun 2010 12:46:02 GMT
Author: aadamchik
Date: Tue Jun 15 12:46:01 2010
New Revision: 954855

URL: http://svn.apache.org/viewvc?rev=954855&view=rev
Log:
comments, naming refactoring

Modified:
    cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java

Modified: cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java?rev=954855&r1=954854&r2=954855&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java
(original)
+++ cayenne/main/trunk/framework/cayenne-di-unpublished/src/main/java/org/apache/cayenne/di/spi/DefaultScope.java
Tue Jun 15 12:46:01 2010
@@ -104,6 +104,11 @@ public class DefaultScope implements Sco
 
     public void removeScopeEventListener(Object object) {
 
+        // TODO: 2 level-deep full scan will not be very efficient for short scopes. Right
+        // now this would only affect the unit test scope, but if we start creating the
+        // likes of HTTP request scope, we may need to create a faster listener
+        // removal algorithm.
+
         for (Entry<String, Collection<ScopeEventBinding>> entry : listeners.entrySet())
{
 
             if (SPECIAL_EVENT.equals(entry.getKey())) {



Mime
View raw message