cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrus Adamchik (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CAY-1293) Beta 1 Test Failures
Date Thu, 15 Oct 2009 18:08:31 GMT

     [ https://issues.apache.org/jira/browse/CAY-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrus Adamchik updated CAY-1293:
---------------------------------

          Component/s: Cayenne Core Library
    Affects Version/s: 3.0 beta 1
             Assignee: Andrus Adamchik
              Summary: Beta 1 Test Failures  (was: Beta 1 Test Failed)

Hi Olga! great job tracking all those obscure bugs. I committed your patch, removing just
a few changesets that were simply reformatting the code. I have my doubts about the piece
below though. I did not commit it with the rest of the patch, pending a discussion on its
purpose.


Index: framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
===================================================================
--- framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
(revision 825496)
+++ framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
(working copy)
@@ -30,6 +30,7 @@
 import java.util.List;
 import java.util.Map;
 
+import org.apache.cayenne.exp.parser.ASTNot;
 import org.apache.cayenne.exp.parser.ASTScalar;
 import org.apache.cayenne.exp.parser.ExpressionParser;
 import org.apache.cayenne.exp.parser.ParseException;
@@ -523,7 +524,9 @@
             boolean prune = transformer != null && transformedChild == PRUNED_NODE;
 
             if (!prune) {
-                copy.setOperand(j, transformedChild);
+                if (!(copy instanceof ASTNot)) {
+                    copy.setOperand(j, transformedChild);
+                }
                 j++;
             }
 


> Beta 1 Test Failures
> --------------------
>
>                 Key: CAY-1293
>                 URL: https://issues.apache.org/jira/browse/CAY-1293
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Cayenne Core Library
>    Affects Versions: 3.0 beta 1
>            Reporter: Olga Tkachova
>            Assignee: Andrus Adamchik
>             Fix For: 3.0 beta 1
>
>         Attachments: FixErrorsAndFaild.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message