cayenne-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kmen...@apache.org
Subject svn commit: r688345 - in /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb: ./ HSQLDBAdapterTest.java
Date Sat, 23 Aug 2008 15:51:26 GMT
Author: kmenard
Date: Sat Aug 23 08:51:26 2008
New Revision: 688345

URL: http://svn.apache.org/viewvc?rev=688345&view=rev
Log:
Fixed CAY-1095: Cayenne attempts to append precision information to DOUBLE types when creating
tables in hsqldb which results in a sql exception.

Patch by Robert Zeigler.

Added:
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapterTest.java

Added: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapterTest.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapterTest.java?rev=688345&view=auto
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapterTest.java
(added)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapterTest.java
Sat Aug 23 08:51:26 2008
@@ -0,0 +1,58 @@
+/*****************************************************************
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ ****************************************************************/
+
+package org.apache.cayenne.dba.hsqldb;
+
+import java.sql.Types;
+
+import junit.framework.TestCase;
+
+import org.apache.cayenne.map.DbAttribute;
+import org.apache.cayenne.map.DbEntity;
+
+public class HSQLDBAdapterTest extends TestCase {
+
+    public void testCreateTableIgnoresDoublePrecision() {
+        HSQLDBAdapter adapter = new HSQLDBAdapter();
+        DbEntity e = new DbEntity("Test");
+        DbAttribute dblPrec = new DbAttribute("dbl1");
+        dblPrec.setType(Types.DOUBLE);
+        dblPrec.setMaxLength(22);
+        e.addAttribute(dblPrec);
+        
+        String sql = adapter.createTable(e);
+
+        // CAY-1095.
+        // Make sure the double type is preserved, but not precision constraints, due to
a bug in HSQLDB.
+        assertTrue(sql.indexOf("DOUBLE") > 0);
+        assertEquals(-1, sql.indexOf("DOUBLE(22)"));
+    }
+    
+    public void testCreateTableAddsCachedKeyword() {
+        HSQLDBAdapter adapter = new HSQLDBAdapter();
+        DbEntity e = new DbEntity("Test");
+        DbAttribute dblPrec = new DbAttribute("dbl1");
+        dblPrec.setType(Types.INTEGER);
+        e.addAttribute(dblPrec);
+        
+        String sql = adapter.createTable(e);
+        
+        assertEquals(0,sql.indexOf("CREATE CACHED TABLE"));
+    }
+}



Mime
View raw message