Return-Path: Delivered-To: apmail-incubator-cayenne-commits-archive@locus.apache.org Received: (qmail 37212 invoked from network); 2 Sep 2006 14:28:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Sep 2006 14:28:59 -0000 Received: (qmail 47105 invoked by uid 500); 2 Sep 2006 14:28:59 -0000 Delivered-To: apmail-incubator-cayenne-commits-archive@incubator.apache.org Received: (qmail 47095 invoked by uid 500); 2 Sep 2006 14:28:59 -0000 Mailing-List: contact cayenne-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cayenne-dev@incubator.apache.org Delivered-To: mailing list cayenne-commits@incubator.apache.org Received: (qmail 47083 invoked by uid 99); 2 Sep 2006 14:28:59 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Sep 2006 07:28:59 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Sep 2006 07:28:59 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id F17DA1A981A; Sat, 2 Sep 2006 07:28:38 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r439603 - /incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java Date: Sat, 02 Sep 2006 14:28:38 -0000 To: cayenne-commits@incubator.apache.org From: aadamchik@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060902142838.F17DA1A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: aadamchik Date: Sat Sep 2 07:28:38 2006 New Revision: 439603 URL: http://svn.apache.org/viewvc?rev=439603&view=rev Log: a minor glitch in validation routine that failed validation on java non-promitive arrays Modified: incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java Modified: incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java URL: http://svn.apache.org/viewvc/incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java?rev=439603&r1=439602&r2=439603&view=diff ============================================================================== --- incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java (original) +++ incubator/cayenne/main/trunk/core/cayenne-jdk1.4/src/main/java/org/apache/cayenne/validation/BeanValidationFailure.java Sat Sep 2 07:28:38 2006 @@ -154,17 +154,9 @@ " starts with invalid character: " + c)); } - // handle primitive arrays like byte[] + // handle arrays if (identifier.endsWith("[]")) { - for (int i = 1; i < (identifier.length() - 2); i++) { - c = identifier.charAt(i); - if (Character.getType(c) != Character.LOWERCASE_LETTER) { - return new BeanValidationFailure(bean, attribute, validationMessage( - attribute, - " is not a valid Java Class Name: " + identifier)); - } - } - return null; + identifier = identifier.substring(0, identifier.length() - 2); } boolean wasDot = false;