Return-Path: Delivered-To: apmail-incubator-cayenne-commits-archive@locus.apache.org Received: (qmail 7060 invoked from network); 24 May 2006 04:23:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 May 2006 04:23:41 -0000 Received: (qmail 71734 invoked by uid 500); 24 May 2006 04:23:41 -0000 Delivered-To: apmail-incubator-cayenne-commits-archive@incubator.apache.org Received: (qmail 71709 invoked by uid 500); 24 May 2006 04:23:41 -0000 Mailing-List: contact cayenne-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cayenne-dev@incubator.apache.org Delivered-To: mailing list cayenne-commits@incubator.apache.org Received: (qmail 71700 invoked by uid 99); 24 May 2006 04:23:41 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2006 21:23:41 -0700 X-ASF-Spam-Status: No, hits=0.6 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2006 21:23:40 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 0C3251A983A; Tue, 23 May 2006 21:23:19 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r409068 - /incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java Date: Wed, 24 May 2006 04:23:18 -0000 To: cayenne-commits@incubator.apache.org From: aadamchik@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060524042319.0C3251A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: aadamchik Date: Tue May 23 21:23:18 2006 New Revision: 409068 URL: http://svn.apache.org/viewvc?rev=409068&view=rev Log: CAY-525 - saving a few CPU cycles on big result processing by caching the column labels and JDBC types. Modified: incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java Modified: incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java URL: http://svn.apache.org/viewvc/incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java?rev=409068&r1=409067&r2=409068&view=diff ============================================================================== --- incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java (original) +++ incubator/cayenne/main/trunk/cayenne/cayenne-java/src/cayenne/java/org/objectstyle/cayenne/access/jdbc/JDBCResultIterator.java Tue May 23 21:23:18 2006 @@ -105,6 +105,9 @@ protected boolean nextRow; protected int fetchedSoFar; protected int fetchLimit; + + private String[] labels; + private int[] types; /** * Creates new JDBCResultIterator that reads from provided ResultSet. @@ -122,6 +125,19 @@ this.mapCapacity = (int) Math.ceil((descriptor.getWidth()) / 0.75); checkNextRow(); + + if(nextRow) { + // extract column parameters to speed up processing... + ColumnDescriptor[] columns = descriptor.getColumns(); + int width = columns.length; + labels = new String[width]; + types = new int[width]; + + for(int i = 0; i < width; i++) { + labels[i] = columns[i].getLabel(); + types[i] = columns[i].getJdbcType(); + } + } } /** @@ -302,18 +318,17 @@ try { DataRow dataRow = new DataRow(mapCapacity); ExtendedType[] converters = rowDescriptor.getConverters(); - ColumnDescriptor[] columns = rowDescriptor.getColumns(); - int resultWidth = rowDescriptor.getWidth(); + + int resultWidth = labels.length; // process result row columns, for (int i = 0; i < resultWidth; i++) { // note: jdbc column indexes start from 1, not 0 unlike everywhere else - Object val = converters[i].materializeObject(resultSet, i + 1, columns[i] - .getJdbcType()); - dataRow.put(columns[i].getLabel(), val); + Object val = converters[i].materializeObject(resultSet, i + 1, types[i]); + dataRow.put(labels[i], val); } - - if(postProcessor != null) { + + if (postProcessor != null) { postProcessor.postprocessRow(resultSet, dataRow); } @@ -337,7 +352,6 @@ try { DataRow idRow = new DataRow(2); ExtendedType[] converters = rowDescriptor.getConverters(); - ColumnDescriptor[] columns = rowDescriptor.getColumns(); int len = pkIndices.length; for (int i = 0; i < len; i++) { @@ -349,11 +363,11 @@ Object val = converters[index].materializeObject( resultSet, index + 1, - columns[index].getJdbcType()); - idRow.put(columns[index].getLabel(), val); + types[index]); + idRow.put(labels[index], val); } - - if(postProcessor != null) { + + if (postProcessor != null) { postProcessor.postprocessRow(resultSet, idRow); }